Fix infinite loop on Windows caused by checking path against "/". #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that it depends on what you are using. Particularly with swift-foundation, it should be |
compnerd
reviewed
Sep 4, 2024
| @@ -415,7 +415,7 @@ public struct Configuration: Codable, Equatable { | |||
| if FileManager.default.isReadableFile(atPath: candidateFile.path) { | |||
| return candidateFile | |||
| } | |||
| } while candidateDirectory.path != "/" | |||
| } while candidateDirectory.pathComponents.count > 1 | |||
There was a problem hiding this comment.
The concern that I have with this on Windows is that this would return true for C: and \, both of which are relative paths.
compnerd
approved these changes
Sep 5, 2024
allevato
approved these changes
Sep 6, 2024
ahoppen
added a commit
to ahoppen/swift-format
that referenced
this pull request
Oct 10, 2024
…'t contain a `.swift-format` file swiftlang#802 this sort of infinite looping issue on Windows but introduced it on Unix platforms where `URL.deletingLastPathComponent` on `/` returns `/..`.
ahoppen
added a commit
to ahoppen/swift-format
that referenced
this pull request
Oct 10, 2024
…'t contain a `.swift-format` file swiftlang#802 this sort of infinite looping issue on Windows but introduced it on Unix platforms where `URL.deletingLastPathComponent` on `/` returns `/..`.
ahoppen
added a commit
to ahoppen/swift-format
that referenced
this pull request
Oct 11, 2024
…'t contain a `.swift-format` file swiftlang#802 this sort of infinite looping issue on Windows but introduced it on Unix platforms where `URL.deletingLastPathComponent` on `/` returns `/..`. # Conflicts: # Sources/SwiftFormat/API/Configuration.swift
ahoppen
added a commit
to ahoppen/swift-format
that referenced
this pull request
Oct 11, 2024
…'t contain a `.swift-format` file swiftlang#802 this sort of infinite looping issue on Windows but introduced it on Unix platforms where `URL.deletingLastPathComponent` on `/` returns `/..`.
ahoppen
added a commit
to ahoppen/swift-format
that referenced
this pull request
Oct 11, 2024
…'t contain a `.swift-format` file swiftlang#802 this sort of infinite looping issue on Windows but introduced it on Unix platforms where `URL.deletingLastPathComponent` on `/` returns `/..`.
ahoppen
added a commit
to ahoppen/swift-format
that referenced
this pull request
Oct 11, 2024
…'t contain a `.swift-format` file swiftlang#802 this sort of infinite looping issue on Windows but introduced it on Unix platforms where `URL.deletingLastPathComponent` on `/` returns `/..`.
This was referenced Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #694.