Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite loop on Windows caused by checking path against "/". #802

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Fix infinite loop on Windows caused by checking path against "/". #802

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c050187
Fix infinite loop on Windows caused by checking path against "/".
shawnhyam Sep 4, 2024
750d9a5
Change loop termination check based on feedback.
shawnhyam Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/SwiftFormat/API/Configuration.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ public struct Configuration: Codable, Equatable {
if FileManager.default.isReadableFile(atPath: candidateFile.path) {
return candidateFile
}
} while candidateDirectory.path != "/"
} while candidateDirectory.pathComponents.count > 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The concern that I have with this on Windows is that this would return true for C: and \, both of which are relative paths.


return nil
}
Expand Down