URL.deletingLastPathComponent() should append .. in special cases
#989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
itingliu
approved these changes
Oct 18, 2024
| XCTAssertEqual(relative.path, "/absolute/relative") | ||
|
|
||
| relative.deleteLastPathComponent() | ||
| checkBehavior(relative.relativePath, new: "", old: ".") |
There was a problem hiding this comment.
Are there scenarios where this difference between "" and "." would actually matter? The only thing I can think of is existing clients using the string literally somewhere else, so this change of behavior breaks their expectation.
There was a problem hiding this comment.
Yeah, I don't feel too strongly about returning "" over ".", so I think I will make the change to return "." and maximize compatibility. I could see a client recursively calling .deletingLastPathComponent() until the relative path matches ".". I'll edit this PR and #988
We can do this while still accepting URL(string: "", relativeTo: base) initialization to pass all RFC 3986 examples.
jrflat
force-pushed
the
deleting-path-special-cases
branch
from
438494e
to
3eef139
Compare
|
@swift-ci please test |
jrflat
added a commit
to jrflat/swift-foundation
that referenced
this pull request
Oct 29, 2024
jrflat
added a commit
that referenced
this pull request
Nov 4, 2024
cthielen
pushed a commit
to cthielen/swift-foundation
that referenced
this pull request
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a URL's relative path is being resolved against a base URL, we should append ".." as a means of deleting the last path component in the following cases:
Otherwise, we can just remove the last path component as normal.