Skip to content

Use FileHandle for reading/writing in JSONRPCConnection #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnbarham merged 3 commits into from
Dec 5, 2025
Merged

Use FileHandle for reading/writing in JSONRPCConnection #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
678dc1b
Use `FileHandle` for reading/writing in `JSONRPCConnection`
bnbarham Nov 22, 2025
e18a5b5
Migrate off of `readabilityHandler` to our own read loop
bnbarham Dec 4, 2025
5128cc8
Move writing to `sendFD` onto its own queue
bnbarham Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions Sources/LanguageServerProtocolTransport/DisableSigpipe.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,35 +10,32 @@
//
//===----------------------------------------------------------------------===//

#if canImport(Glibc)
#if canImport(Darwin)
import Darwin
#elseif canImport(Glibc)
import Glibc
#elseif canImport(Musl)
import Musl
#elseif canImport(Android)
import Android
#endif

#if canImport(Glibc) || canImport(Musl) || canImport(Android)
#if !os(Windows)
// This is a lazily initialised global variable that when read for the first time, will ignore SIGPIPE.
private let globallyIgnoredSIGPIPE: Bool = {
/* no F_SETNOSIGPIPE on Linux :( */
// No F_SETNOSIGPIPE on Linux
_ = signal(SIGPIPE, SIG_IGN)
return true
}()
#endif

/// We receive a `SIGPIPE` if we write to a pipe that points to a crashed process. This in particular happens if the
/// target of a `JSONRPCConnection` has crashed and we try to send it a message or if swift-format crashes and we try
/// to send the source file to it.
/// We receive a `SIGPIPE` if we write to a closed pipe. This can happen if the target of a `JSONRPCConnection` has
/// crashed and we try to receive/send messages, or if eg. swift-format crashes and we try to send the source file to
/// it.
///
/// On Darwin, `DispatchIO` ignores `SIGPIPE` for the pipes handled by it and swift-tools-support-core offers
/// `LocalFileOutputByteStream.disableSigpipe`, but that features is not available on Linux.
///
/// Instead, globally ignore `SIGPIPE` on Linux to prevent us from crashing if the `JSONRPCConnection`'s target crashes.
///
/// On Darwin platforms and on Windows this is a no-op.
/// Globally ignore `SIGPIPE` across platforms to prevent us from crashing in these cases. This is a no-op on Windows.
package func globallyDisableSigpipeIfNeeded() {
#if !canImport(Darwin) && !os(Windows)
#if !os(Windows)
let haveWeIgnoredSIGPIEThisIsHereToTriggerIgnoringIt = globallyIgnoredSIGPIPE
guard haveWeIgnoredSIGPIEThisIsHereToTriggerIgnoringIt else {
fatalError("globallyIgnoredSIGPIPE should always be true")
Expand Down
Loading