[darwin][build] Copy the libclang_rt.{ios/tvos/watchos}.a from toolchain to the build dir so that swift-clang can use them when building for ios/tvos/watchos #25547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please clean smoke test |
…ain to the build dir so that swift-clang can use them when building for ios/tvos/watchos
hyp
changed the title
Contributor
Author
|
@swift-ci Please clean smoke test |
Rostepher
reviewed
Jun 19, 2019
| # builtins for iOS/tvOS/watchOS to ensure that Swift's | ||
| # stdlib can use compiler-rt builtins when targetting iOS/tvOS/watchOS. | ||
| if [[ "${product}" == "llvm" ]]; then | ||
| if [[ "$(uname -s)" == "Darwin" ]] ; then |
Contributor
There was a problem hiding this comment.
Any reason these if statements aren't combined into one?
Rostepher
reviewed
Jun 19, 2019
| if [[ "${product}" == "llvm" ]]; then | ||
| if [[ "$(uname -s)" == "Darwin" ]] ; then | ||
| HOST_CXX_DIR=$(dirname "${HOST_CXX}") | ||
| HOST_CXX_BUILTINS_VERSION=$(ls "$HOST_CXX_DIR/../lib/clang" | awk '{print $0}') |
Contributor
There was a problem hiding this comment.
What happens if this directory isn't there?
Contributor
There was a problem hiding this comment.
This broke my compilation because it's expanding to
4.0.0
5.0.0
6.0.0
7.0.0
…newlines included. I know that's probably not normal but it'd be good to handle.
Rostepher
reviewed
Jun 19, 2019
|
|
||
| echo "copying compiler-rt embedded builtins into the local clang build directory $DEST_BUILTINS_DIR." | ||
|
|
||
| if [ -f "$HOST_CXX_BUILTINS_DIR/libclang_rt.ios.a" ]; then |
Contributor
There was a problem hiding this comment.
We should probably keep using the [[ syntax here for tests.
edymtt
added a commit
to edymtt/swift
that referenced
this pull request
Apr 22, 2020
Similarly to what was done for swiftlang#25547, copy the compiler-rt built-ins for embedded platforms from the Xcode toolchain into the new generated one, so to avoid link time errors. Addresses SR-12001, rdar://57837918
edymtt
added a commit
to edymtt/swift
that referenced
this pull request
Apr 23, 2020
Similarly to what was done for swiftlang#25547, copy the compiler-rt built-ins for embedded platforms from the Xcode toolchain into the new generated one, so to avoid link time errors. Addresses SR-12001, rdar://57837918
edymtt
added a commit
to edymtt/swift
that referenced
this pull request
Oct 8, 2020
Similarly to what was done for swiftlang#25547, copy the compiler-rt built-ins for embedded platforms from the Xcode toolchain into the new generated one, so to avoid link time errors. Addresses SR-12001, rdar://57837918 Cherry-pick of swiftlang#31247 -- this also brings in the improvements from swiftlang#34049
edymtt
added a commit
that referenced
this pull request
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to build compiler_rt for iOS/watchOS/tvOS.