Ensure CMark is not tested by default #67459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`test_cmark` is set by default to `True` because of the indirect way we define it through `--skip-test-cmark` -- we want instead the user to opt in into this explicitly, as CMark tests on their own have little value when building as part of Swift. Addresses rdar://112604393
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test toolchain |
shahmishal
approved these changes
Jul 21, 2023
drexin
approved these changes
Jul 21, 2023
al45tair
approved these changes
Jul 22, 2023
Contributor
Author
|
@swift-ci please python lint |
Contributor
Author
|
Verified that the Linux job built cmark, but did not run its tests -- the macOS PR already skips these tests as a result of #35361 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_cmarkis set by default toTruebecause of the indirect way we define it through--skip-test-cmark-- we want instead the user to opt in into this explicitly, as CMark tests on their own have little value when building as part of Swift.Addresses rdar://112604393