Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use common code paths for constructor concurrency prologs #77600

Conversation

rjmccall
Copy link
Contributor

@rjmccall rjmccall commented Nov 13, 2024

…if we're not in the async self-isolated actor initializer case.

Fixes rdar://138394497 and #71174, bugs where we didn't set up isolation correctly for an async parameter-isolated initializer, but also probably a non-trivial number of other latent differences between initializers and normal functions.

…t in

the async self-isolated actor initializer case.

Fixes rdar://138394497, a bug where we didn't set up isolation correctly for
an async parameter-isolated initializer, but also probably a non-trivial number
of other latent differences between initializers and normal functions.
@rjmccall
Copy link
Contributor Author

@swift-ci Please test

Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, lgtm 👍

@rjmccall rjmccall merged commit 5ffdfb9 into swiftlang:main Nov 14, 2024
5 checks passed
@rjmccall rjmccall deleted the simplify-constructor-concurrency-prolog-emission branch November 14, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants