Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font family when using font awesome #433

Closed
saschaende opened this issue Jul 28, 2016 · 7 comments
Closed

Font family when using font awesome #433

saschaende opened this issue Jul 28, 2016 · 7 comments
Labels

Comments

@saschaende
Copy link

saschaende commented Jul 28, 2016

You should add something like this...

.context-menu-icon.context-menu-icon--fa span { font-family: Arial; }

Otherwise the font in the menu is wrong (looks like time new roman, in fact it is "FontAwesome")

@bbrala bbrala added the Bug label Aug 1, 2016
@bbrala
Copy link
Member

bbrala commented Aug 1, 2016

Thanks for reporting, i noticed something strange also yeah.

@gaurav6192
Copy link

@bbrala any updates?

@bbrala
Copy link
Member

bbrala commented Aug 25, 2016

Sorry no, I haven't made the time yet to get back up to speed with the issues. I will make sure to reserve some time in the coming week.

@bbrala
Copy link
Member

bbrala commented Aug 26, 2016

I added a demo to the documentation, i don't see the issue there.

@bbrala bbrala closed this as completed Aug 26, 2016
@gaurav6192
Copy link

@bbrala so just checked out the code there on the demo page, looks like there is this custom styling which is making it work -

.fa, .rst-content .admonition-title, .rst-content h1 .headerlink, .rst-content h2 .headerlink, .rst-content h3 .headerlink, .rst-content h4 .headerlink, .rst-content h5 .headerlink, .rst-content h6 .headerlink, .rst-content dl dt .headerlink, .icon, .wy-dropdown .caret, .wy-inline-validate.wy-inline-validate-success .wy-input-context, .wy-inline-validate.wy-inline-validate-danger .wy-input-context, .wy-inline-validate.wy-inline-validate-warning .wy-input-context, .wy-inline-validate.wy-inline-validate-info .wy-input-context { font-family: inherit; }

Adding .fa{font-family: inherit;} to the css is making it work fine.

@gaurav6192
Copy link

Though the styling will still not be same as the one when using default context-menu icons. Try using one of each.

@bbrala
Copy link
Member

bbrala commented Aug 26, 2016

Thanks for looking, didnt look deep enough appearantly. Sorry about that.

@bbrala bbrala reopened this Aug 26, 2016
@bbrala bbrala closed this as completed in b3dcf74 Aug 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants