Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dockerfile and docker-compose.yml #14

Merged
merged 115 commits into from
Sep 15, 2023
Merged

Add Dockerfile and docker-compose.yml #14

merged 115 commits into from
Sep 15, 2023

Conversation

acerioni
Copy link
Member

@acerioni acerioni commented Sep 8, 2023

⚠️ The README.md must be updated.

acerioni added 30 commits March 13, 2023 15:55
@acerioni
Add GitHub action for SonarQube
bd0bcaf
@acerioni
Add sonar-project.properties
080780a
@acerioni
Remove unused variable
51948a5
@acerioni
Enable server certificate validation on SSL/TLS connection
918118a
@acerioni
Define DEMO_MSG constant in order to avoid duplication
880a0f2
@acerioni
Introduce LabelOverflowException
7ebf10a
@acerioni
ACheck and extract x, y, z coordinates from tile IDs at once
ae79029
@acerioni
Do not ignore insecure request warnings
507ae22
@acerioni
Remove unused imports
1854473
@acerioni
Introduce and handle custom exceptions for the COCO module
35e7ae2
@acerioni
Remove unexpected argument in logger.warning call
ea530c8
@acerioni
Use specific exception instead of a generic one. Rename variables sta…
c152550 
…rting with the_
@acerioni
Introduce and handle custom exceptions. Rename variables starting wit…
5564576 
…h "the_"
@acerioni
Rename _PolyArea method as _compute_polygon_area
3b7114f
@acerioni
Remove TODO messages
0e95411
@acerioni
Introduce BadFileExtensionException and UnsupportedImageFormatException
fcc0f3f
@acerioni
Use custom exception "BadFileExtensionException"
52d0c7f
@acerioni
Rename variables in order to comply with Python naming conventions
6c1a6a0
@acerioni
Remove useless f-strings
42a4782
@acerioni
Add SCATTER_PLOT_MODE constant
925c279
@acerioni
Update requirements.in and requirements.txt in order to faddress Depe…
af51109 
…ndabot vulnerability alerts
@acerioni
Remove extra blank space. Use "md_filename" variable instead of equiv…
b17d22d 
…alent expression
@acerioni
Ignore UserWarning, cf. facebookresearch/detectron2#3983
fb49467
@acerioni
Remove useless imports
ab66817
@acerioni
Remove commented-out line
6e2d3b5
@acerioni
Better handle constants (e.g. DONE_MSG)
c645f3d
@acerioni
Remove useless imports
7b82c40
@acerioni
Use loguru instead of logging
1bbb612
@acerioni
Fix XYZ connector
2e6da72
@acerioni @cleherny
Add setup.py and adapt scripts to be used as console scripts
9360c36
@stdl-s-sonarqube

This comment has been minimized.

Sign in to view
@acerioni
Copy link
Member Author

It looks very nice! I have some minor comments:

* You have added some functions such as the "DONE_MSG". For the sake of homogeneity, I can add it to the quarry scripts as well (along with changing some logger.info to logger.success). I can do it.

* From PEP8 (https://peps.python.org/pep-0008/) it is advised to separate imports:
  ![image](https://user-images.githubusercontent.com/77794618/267081938-d751daf8-dfc3-426b-9bac-29ecf44c3e2c.png)
  for instance `import os, sys`

* The main README.md and the ones from swimming pool examples (environment and path to scripts) should be updated before being merged to master.

It's now done!

@stdl-s-sonarqube

This comment has been minimized.

Sign in to view
@stdl-s-sonarqube

This comment has been minimized.

Sign in to view
@acerioni acerioni requested a review from cleherny September 15, 2023 12:30
cleherny and others added 13 commits September 15, 2023 14:31
@stdl-s-sonarqube

This comment has been minimized.

Sign in to view
@cleherny
Merge pull request #18 from swiss-territorial-data-lab/ac/rename-pred…
81a0e6b 
…ictions-detections

Rename predictions -> detections
@stdl-s-sonarqube
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (0.00% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: swiss-territorial-data-lab_object-detector_AYZ4zWIzr7JdaaSXwexc

View in SonarQube

cleherny
cleherny approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@cleherny cleherny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a final checking, it looks all good for me!

@cleherny cleherny merged commit 08f245f into master Sep 15, 2023
1 check passed
@acerioni acerioni deleted the ac/add-docker branch December 13, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleherny cleherny cleherny approved these changes

Assignees

@acerioni acerioni

@cleherny cleherny

Labels
None yet
Projects
None yet
Milestone
First tagged version (v1.0)
Development

Successfully merging this pull request may close these issues.
2 participants
@acerioni @cleherny