Using Vite 4 Modal Failing to Open

[codylindley]

FYI Something is failing, when using Vite 4.

Click modal, nothing happens.

https://stackblitz.com/edit/angular-vmqvmy-lv8str?file=src%2FApp.tsx,package.json

But Vite Build, it works.

Change Vite to 3.2.5 and works again.

[NinoM4ster]

Can confirm, just tried updating all packages in a project and the vite v4.0.1 + @suid/vite-plugin v0.1.0 combination is giving me the error Make sure your app is wrapped in a <Router />, even though it's definitely wrapped.

vite v3.2.5 + @suid/vite-plugin v0.1.0 works as expected. (I haven't tested vite build on either versions)

Here's some other console warnings that I haven't seen before this:

You appear to have multiple instances of Solid. This can lead to unexpected behavior.

cleanups created outside a `createRoot` or `render` will never be run

computations created outside a `createRoot` or `render` will never be disposed

[NinoM4ster]

Related to/Duplicate of #156

[juanrgm]

Is it a SolidJS issue? (solidjs/solid#1426)

[juanrgm]

This was fixed in Vite v4.0.2 (https://stackblitz.com/edit/angular-vmqvmy-uqqlfj?file=package.json).

[NinoM4ster]

@juanrgm just noting that pnpm still shows a warning with vite 4.0.2:

Is testing under way to bump the dependency version?

[IronGeek]

@juanrgm if @suid/vite-plugin does work with vite v4.0.2, please bump the peer dependency version to:

  "vite": "^3.0.0 || ^4.0.2"

right now it still consider vite 4 as unmet dependency

suid/packages/vite-plugin/package.json

Lines 37 to 39 in c07d2d0

	"peerDependencies": {
	"vite": "^3.0.0"
	},