From 6712534ebc6f84f0b178a19bf17b7b2bd852f6eb Mon Sep 17 00:00:00 2001 From: Arthur O'Dwyer Date: Thu, 29 Apr 2021 17:32:17 -0400 Subject: [PATCH] [libc++] [test] Run the clang-format and generated-output checks on the "service" queue As these jobs only run in a couple seconds, and block starting of other jobs, they can run on the "service" queue which doesn't get blocked by other long-running jobs. Differential Revision: https://reviews.llvm.org/D101437 --- libcxx/utils/ci/buildkite-pipeline.yml | 4 ++-- libcxx/utils/ci/run-buildbot | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/libcxx/utils/ci/buildkite-pipeline.yml b/libcxx/utils/ci/buildkite-pipeline.yml index 1023d7430b14..ecfbac8ec793 100644 --- a/libcxx/utils/ci/buildkite-pipeline.yml +++ b/libcxx/utils/ci/buildkite-pipeline.yml @@ -27,7 +27,7 @@ steps: artifact_paths: - "**/clang-format.patch" agents: - queue: "libcxx-builders" + queue: "service" retry: automatic: - exit_status: -1 # Agent was lost @@ -40,7 +40,7 @@ steps: artifact_paths: - "**/generated_output.patch" agents: - queue: "libcxx-builders" + queue: "service" retry: automatic: - exit_status: -1 # Agent was lost diff --git a/libcxx/utils/ci/run-buildbot b/libcxx/utils/ci/run-buildbot index 1042b110f2bf..17cb85b886ac 100755 --- a/libcxx/utils/ci/run-buildbot +++ b/libcxx/utils/ci/run-buildbot @@ -9,6 +9,9 @@ set -ex set -o pipefail +unset LANG +unset LC_ALL +unset LC_COLLATE PROGNAME="$(basename "${0}")" @@ -146,6 +149,7 @@ check-generated-output) # Check if the diffs are empty, fail otherwise. ! grep -q '^--- a' ${BUILD_DIR}/generated_output.patch || false # Reject patches that introduce non-ASCII characters or hard tabs. + # Depends on LC_COLLATE set at the top of this script. ! grep -rn '[^ -~]' libcxx/include/ || false # Check that no dependency cycles have been introduced. python3 libcxx/utils/graph_header_deps.py >/dev/null