Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'wget' dependency not mentioned in the documentation #19

Open
OliverJennrich opened this issue Mar 31, 2021 · 1 comment
Open

'wget' dependency not mentioned in the documentation #19

OliverJennrich opened this issue Mar 31, 2021 · 1 comment

Comments

@OliverJennrich
Copy link

Documentation should mention dependency on 'wget'. Alternatively, pul() should fail with an appropriate error message if 'wget' cannot be found/executed. At the moment it fails silently.

Suggestion:
In line 252 in catalog.py check the return of os.systeM('wget....') through os.WEXITSTATUS() and fail if it is not zero, i.e.

if os.WEXITSTATUS( os.system('wget -q --directory-prefix='+sdir+' '+surr_url)) >0:
raise ValueError("wget not installed")

@duetosymmetry
Copy link
Member

For this one and #20, maybe we should just move away from using wget to fetch data. We can use urllib.request (the legacy function urlretrieve writes to disk for you and hasn't been deprecated yet). Do we really need to use wget?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants