Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly dispose of effects #32

Closed
1 of 3 tasks
lukechu10 opened this issue Mar 10, 2021 · 0 comments · Fixed by #37
Closed
1 of 3 tasks

Properly dispose of effects #32

lukechu10 opened this issue Mar 10, 2021 · 0 comments · Fixed by #37
Assignees
@lukechu10
Labels
A-reactivity Area: reactivity and state handling C-bug Category: bug, something isn't working

Comments

@lukechu10
Copy link
Member

Describe the bug
Effects should be owned by a reactivity root, created using a create_root method.

Questionnaire

  • I would like to fix this bug but I don't know where to start
  • I would like to fix this bug and I have a solution
  • I don't have time to implement this / I don't want to implement this
@lukechu10 lukechu10 added C-bug Category: bug, something isn't working A-reactivity Area: reactivity and state handling labels Mar 10, 2021
@lukechu10 lukechu10 self-assigned this Mar 10, 2021
This was referenced Mar 10, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukechu10 lukechu10

Labels
A-reactivity Area: reactivity and state handling C-bug Category: bug, something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create effects within a reactivity root sycamore-rs/sycamore
1 participant
@lukechu10