Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cross network retry #337

Merged
merged 31 commits into from
Nov 4, 2024
Merged

feat: cross network retry #337

merged 31 commits into from
Nov 4, 2024

Conversation

mpetrun5
Copy link
Collaborator

Implement retry function that can be called from one chain and can execute deposits from another chain.

Description

Related Issue Or Context

Closes: #327

How Has This Been Tested? Testing details.

Still needs new solidity contract version to add proper E2E tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@github-actions GitHub Actions
Copy link
Contributor

Go Test coverage is 68.4 %\ ✨ ✨ ✨

@github-actions GitHub Actions
Copy link
Contributor

Go Test coverage is 68.4 %\ ✨ ✨ ✨

@github-actions GitHub Actions
Copy link
Contributor

Go Test coverage is 68.6 %\ ✨ ✨ ✨

@github-actions GitHub Actions
Copy link
Contributor

Go Test coverage is 68.6 %\ ✨ ✨ ✨

@github-actions GitHub Actions
Copy link
Contributor

Go Test coverage is 68.6 %\ ✨ ✨ ✨

@github-actions GitHub Actions
Copy link
Contributor

Go Test coverage is 68.3 %\ ✨ ✨ ✨

@github-actions GitHub Actions
Copy link
Contributor

Go Test coverage is 67.5 %\ ✨ ✨ ✨

@github-actions GitHub Actions
Copy link
Contributor

Go Test coverage is 67.6 %\ ✨ ✨ ✨

@github-actions GitHub Actions
Copy link
Contributor

Go Test coverage is 67.6 %\ ✨ ✨ ✨

@github-actions GitHub Actions
Copy link
Contributor

Go Test coverage is 67.6 %\ ✨ ✨ ✨

@github-actions GitHub Actions
Copy link
Contributor

Go Test coverage is 67.5 %\ ✨ ✨ ✨

@github-actions GitHub Actions
Copy link
Contributor

Go Test coverage is 67.6 %\ ✨ ✨ ✨

MakMuftic
MakMuftic requested changes Oct 31, 2024
View reviewed changes
app/app.go Outdated Show resolved Hide resolved
chains/evm/executor/message-handler.go Outdated Show resolved Hide resolved
@mpetrun5 mpetrun5 requested a review from MakMuftic October 31, 2024 15:27
@github-actions GitHub Actions
Copy link
Contributor

Go Test coverage is 67.5 %\ ✨ ✨ ✨

MakMuftic
MakMuftic approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@MakMuftic MakMuftic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mpetrun5 mpetrun5 merged commit eb43206 into main Nov 4, 2024
8 checks passed
@mpetrun5 mpetrun5 deleted the mpetrun5/retry-v2 branch November 4, 2024 16:58
@MakMuftic MakMuftic mentioned this pull request Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmlinaric nmlinaric nmlinaric approved these changes

@MakMuftic MakMuftic MakMuftic approved these changes

@tcar121293 tcar121293 Awaiting requested review from tcar121293 tcar121293 is a code owner

@freddyli7 freddyli7 Awaiting requested review from freddyli7 freddyli7 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Retry event and message handlers
3 participants
@mpetrun5 @MakMuftic @nmlinaric