Fixing windows bug where C:/ slash may already be normalized

symfony · Feb 27, 2018 · abbe8d9 · abbe8d9
1 parent 20df636
commit abbe8d9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/FileManager.php b/src/FileManager.php
@@ -136,8 +136,8 @@ public function absolutizePath($path): string
             return $path;
         }
 
-        // support windows drive paths: C:\
-        if (1 === strpos($path, ':\\')) {
+        // support windows drive paths: C:\ or C:/
+        if (1 === strpos($path, ':\\') || 1 === strpos($path, ':/')) {
             return $path;
         }
 

diff --git a/tests/FileManagerTest.php b/tests/FileManagerTest.php
@@ -80,5 +80,11 @@ public function getAbsolutePathTests()
             'D:\foo\bar',
             'D:\foo\bar',
         ];
+
+        yield 'windows_already_absolute_path' => [
+            'D:\path\to\project',
+            'D:/foo/bar',
+            'D:/foo/bar',
+        ];
     }
 }