From 8a77003dadab6a2fc95737b524222f7ddd529da6 Mon Sep 17 00:00:00 2001 From: Tony Cosentino Date: Tue, 25 Mar 2014 19:58:56 +0100 Subject: [PATCH 1/6] Fixed event listeners priority --- reference/dic_tags.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/reference/dic_tags.rst b/reference/dic_tags.rst index aaa546b5692..f3084e3a8fb 100644 --- a/reference/dic_tags.rst +++ b/reference/dic_tags.rst @@ -463,9 +463,9 @@ To register your warmer with Symfony, give it the ``kernel.cache_warmer`` tag: ->addTag('kernel.cache_warmer', array('priority' => 0)) ; -The ``priority`` value is optional, and defaults to 0. This value can be -from -255 to 255, and the warmers will be executed in the order of their -priority. +The ``priority`` value is optional, and defaults to 0. The core Symfony +listeners priorities varies from -1024 to 1024, and the warmers will be +executed in the order of their priority. .. _dic-tags-kernel-event-listener: From 6b745ff2924ccb9c7d85c3826c2ca8d5f3b5d05e Mon Sep 17 00:00:00 2001 From: Tony Cosentino Date: Tue, 25 Mar 2014 22:41:48 +0100 Subject: [PATCH 2/6] Fixed event listeners priority (typos after review) --- reference/dic_tags.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reference/dic_tags.rst b/reference/dic_tags.rst index f3084e3a8fb..3206d33cc57 100644 --- a/reference/dic_tags.rst +++ b/reference/dic_tags.rst @@ -464,7 +464,7 @@ To register your warmer with Symfony, give it the ``kernel.cache_warmer`` tag: ; The ``priority`` value is optional, and defaults to 0. The core Symfony -listeners priorities varies from -1024 to 1024, and the warmers will be +listeners priorities vary from -1024 to 1024 and the warmers will be executed in the order of their priority. .. _dic-tags-kernel-event-listener: From e40069e7d5df9541e66cb379afd41df5186f9a1e Mon Sep 17 00:00:00 2001 From: Tony Cosentino Date: Wed, 26 Mar 2014 17:38:38 +0100 Subject: [PATCH 3/6] Replaced the priority paragraph with a note and a table --- reference/dic_tags.rst | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/reference/dic_tags.rst b/reference/dic_tags.rst index 3206d33cc57..ebc4ab4d12e 100644 --- a/reference/dic_tags.rst +++ b/reference/dic_tags.rst @@ -463,9 +463,23 @@ To register your warmer with Symfony, give it the ``kernel.cache_warmer`` tag: ->addTag('kernel.cache_warmer', array('priority' => 0)) ; -The ``priority`` value is optional, and defaults to 0. The core Symfony -listeners priorities vary from -1024 to 1024 and the warmers will be -executed in the order of their priority. +.. note:: + + The ``priority`` value is optional, and defaults to 0. + The higher the priority, the sooner it gets executed. + +kernel.cache_warmer +.............. + ++-------------------------------------------------------------------------------------------+-----------+ +| Cache Warmer Class Name | Priority | ++-------------------------------------------------------------------------------------------+-----------+ +| :class:`Symfony\\Bundle\\FrameworkBundle\\CacheWarmer\\TemplatePathsCacheWarmer` | 20 | ++-------------------------------------------------------------------------------------------+-----------+ +| :class:`Symfony\\Bundle\\FrameworkBundle\\CacheWarmer\\RouterCacheWarmer` | 0 | ++-------------------------------------------------------------------------------------------+-----------+ +| :class:`Symfony\\Bundle\\TwigBundle\\CacheWarmer\\TemplateCacheCacheWarmer` | 0 | ++-------------------------------------------------------------------------------------------+-----------+ .. _dic-tags-kernel-event-listener: From 10a972dcdb2e78f97d64584a424e22d5ebcfc4f9 Mon Sep 17 00:00:00 2001 From: Tony Cosentino Date: Wed, 26 Mar 2014 17:54:13 +0100 Subject: [PATCH 4/6] Fixed title underline --- reference/dic_tags.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reference/dic_tags.rst b/reference/dic_tags.rst index ebc4ab4d12e..ad48f9d05d2 100644 --- a/reference/dic_tags.rst +++ b/reference/dic_tags.rst @@ -469,7 +469,7 @@ To register your warmer with Symfony, give it the ``kernel.cache_warmer`` tag: The higher the priority, the sooner it gets executed. kernel.cache_warmer -.............. +................... +-------------------------------------------------------------------------------------------+-----------+ | Cache Warmer Class Name | Priority | From 8b84715b2200fcc1b09827ddb2b266791a5fe3b8 Mon Sep 17 00:00:00 2001 From: Tony Cosentino Date: Wed, 26 Mar 2014 18:04:35 +0100 Subject: [PATCH 5/6] Updated title for the core cache warmers --- reference/dic_tags.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/reference/dic_tags.rst b/reference/dic_tags.rst index ad48f9d05d2..4bc6050dee8 100644 --- a/reference/dic_tags.rst +++ b/reference/dic_tags.rst @@ -468,8 +468,8 @@ To register your warmer with Symfony, give it the ``kernel.cache_warmer`` tag: The ``priority`` value is optional, and defaults to 0. The higher the priority, the sooner it gets executed. -kernel.cache_warmer -................... +Core Cache Warmers +.................. +-------------------------------------------------------------------------------------------+-----------+ | Cache Warmer Class Name | Priority | From 94365489259e567fc5810fb656d723dcbe7956df Mon Sep 17 00:00:00 2001 From: Tony Cosentino Date: Thu, 27 Mar 2014 23:23:27 +0100 Subject: [PATCH 6/6] Fixed title level consistency --- reference/dic_tags.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reference/dic_tags.rst b/reference/dic_tags.rst index 4bc6050dee8..e39e2dedb77 100644 --- a/reference/dic_tags.rst +++ b/reference/dic_tags.rst @@ -469,7 +469,7 @@ To register your warmer with Symfony, give it the ``kernel.cache_warmer`` tag: The higher the priority, the sooner it gets executed. Core Cache Warmers -.................. +~~~~~~~~~~~~~~~~~~ +-------------------------------------------------------------------------------------------+-----------+ | Cache Warmer Class Name | Priority |