Skip to content

[Toolkit] Improve descriptions of Shadcn components #2728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented May 11, 2025

Q A
Bug fix? no
New feature? no
Docs? no
Issues Fix #...
License MIT

@carsonbot carsonbot added Toolkit Status: Needs Review Needs to be reviewed labels May 11, 2025
@Kocal Kocal force-pushed the toolkit/adjust-shadcn-components-description branch from 733eb03 to e3e5e90 Compare May 13, 2025 12:00
@Kocal Kocal merged commit e8a2f04 into symfony:2.x May 13, 2025
2 checks passed
@Kocal Kocal deleted the toolkit/adjust-shadcn-components-description branch May 13, 2025 12:53
Kocal added a commit to Kocal/symfony-ux that referenced this pull request May 13, 2025
Kocal added a commit that referenced this pull request May 13, 2025
…Kocal)

This PR was merged into the 2.x branch.

Discussion
----------

[Toolkit] Update snapshots & fix tests, following #2728

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Docs?         | no <!-- required for new features -->
| Issues        | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT

<!--
Replace this notice by a description of your feature/bugfix.
This will help reviewers and should be a good start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - For new features, provide some code snippets to help understand usage.
 - Features and deprecations must be submitted against branch main.
 - Update/add documentation as required (we can help!)
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
 - Never break backward compatibility (see https://symfony.com/bc).
-->

The tests didn't run on #2728 because I only updated .md files... 😬

Commits
-------

15fac72 [Toolkit] Update snapshots & fix tests, following #2728
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants