Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WP-12538 Excel Import fails when column name is longer than 150 characters #35

Merged
merged 2 commits into from
Oct 24, 2022
Merged

WP-12538 Excel Import fails when column name is longer than 150 characters #35

merged 2 commits into from
Oct 24, 2022

Conversation

jayma91
Copy link

@jayma91 jayma91 commented Oct 21, 2022

WP-12538 Excel Import fails when column name is longer than 150 characters
https://varicent.atlassian.net/browse/WP-12538

notes:

  • added fix to truncate column names to 150 in length
  • no duplicate --> use the truncated col as is
  • duplicate --> truncate a bit more and add _{id} that would make the column name distinct

@jayma91 jayma91 merged commit d045a16 into master Oct 24, 2022
@jayma91 jayma91 deleted the WP-12538 branch October 24, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsantos-varicent rsantos-varicent rsantos-varicent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayma91 @rsantos-varicent