WIP (windows support): stub for supporting windows via fsnotify.v1 #6
Conversation
blaggacao
force-pushed
the
feat-windows
branch
from
67cb48f
to
ec9417f
Compare
blaggacao
force-pushed
the
feat-windows
branch
from
ec9417f
to
eee0bef
Compare
|
Feels good, it built successfully! 💃 |
|
To last commit: I didn't find a more elegant way to avoid this. Maybe this "external dependency" can be removed completely, although a basic one? |
|
Thanks, @blaggacao for your PR. I don't want to duplicate main.go. I think we should look at watch.go. I will have a look into this later this week. |
|
Actually, I found watch.go to be the part that is taken care of by fsnotify. An alternative is to make a wrapper around fsnotify in order to adhere to the watch.go signature. However, this would be a wrapper around a wrapper. Until fsevents gets merged into fsnotify, this would be temporary anyhow... However, I think fsnotify project misses some traction atm. |
| fmt.Printf("Syncing %s (local) to %s (docker-machine %s)\n", *srcpath, *dstpath, machineName) | ||
| Sync(machineName, port, rpath, rpathDir, *verbose) // initial sync | ||
|
|
||
| if *watch { |
There was a problem hiding this comment.
This if statement is the only differing part. I also was not pleased to duplicate whole main.go - Maybe there could be a small wrapper around the actual (darwin) watch.go, which imitates fsnotify.v1 signature?
|
Hey @blaggacao and @mattes, any progress on this? I have been using this library with great success on my OS X machine, but I am about to start a new project with a team where some of the engineers use Windows. Seems like you guys are close, and I'd love to be able to make this library part of the tooling for this new project as well. |
|
@duro I'm afraid, I'm out, as this is no longer a priority for me. |
|
@blaggacao did you go a different route? |
|
Well I'm betting on docker-machine to leverage the docker volume plugin to setup a net protocol file share or an rsync volume. So syncing would be handled by docker. I've seen a proposal, but has no very high prio, I think. |
|
I've added support for Windows in #13. -Dan |
|
Closing in favor of #13 |
No idea, if this works, nor how to build it, so far. But it is a starting point to the best of my knowledge. I would be pleased about some sort of collaboration in order to get this badly needed docker-rsync working on windows...