-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RFQ Guard #2840
Merged
Merged
Add RFQ Guard #2840
Changes from 37 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
b69063b
WIP: guard skeleton
dwasse 1c4ef5f
WIP: add guarddb package
dwasse 43d10b7
WIP: db loop
dwasse 49e9466
Feat: add BridgeRequest model
dwasse 85cbf82
Feat: store bridge request
dwasse 35bf205
Feat: add dispute trigger
dwasse ebb8847
Feat: handle disputed log
dwasse 1aea042
Feat: implement relayMatchesBridgeRequest()
dwasse 9c54eee
Fix: build
dwasse bdbaa7e
Fix: guarddb models
dwasse 7864840
Feat: check verified status in e2e test
dwasse ff7d1ca
Feat: check verified status in TestETHtoETH
dwasse b2d25e9
Feat: add guard cmd
dwasse 76b2e1a
Feat: add embedded guard to relayer
dwasse 278cbb9
Feat: add guard config
dwasse 568acce
Feat: add converter for relayer cfg -> guard cfg
dwasse 24c551e
Feat: add UseEmbeddedGuard flag
dwasse 99834de
Feat: add guard wallet for e2e
dwasse a9174c3
WIP: add TestDispute
dwasse 11196b4
Feat: start relayer / guard within tests
dwasse 880e044
Fix: return valid=false on 'not found' err
dwasse 32ede77
Fix: pass in raw request
dwasse 6ab95e1
Cleanup: logs
dwasse c08e4f5
Feat: add tracing
dwasse b344694
Cleanup: move handlers to handlers.go
dwasse cdd769d
Cleanup: lint
dwasse bb677e0
Cleanup: lint
dwasse ed153b7
[goreleaser]
dwasse 3ab1ce6
Merge branch 'master' into feat/rfq-guard
dwasse afb427b
[goreleaser]
dwasse 6efd100
Fix: inherit txSubmitter from relayer
dwasse f5a00e6
[goreleaser]
dwasse d3011d8
add guard
trajan0x 6982d44
use correct transactor
trajan0x 3544a11
merge master [goreleaser]
trajan0x 9b22148
event parsing
trajan0x e576f34
Merge branch 'master' into feat/rfq-guard [goreleaser]
trajan0x 7ceb0db
fix tests
trajan0x 71133e6
anvil removal [goreleaser]
trajan0x 63e553c
ci again
trajan0x File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! But add tests for the new case.
The addition of the
BridgeDisputeEvent
case in theParseEvent
method is correctly implemented.However, the new lines are not covered by tests. Do you want me to generate the unit testing code or open a GitHub issue to track this task?
Tools
GitHub Check: codecov/patch