Skip to content

Export types from main entry-point #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Methuselah96 wants to merge 1 commit into from
Closed

Export types from main entry-point #11

Methuselah96 wants to merge 1 commit into from

Conversation

@Methuselah96
Copy link
Contributor

@Methuselah96 Methuselah96 commented Jan 23, 2023

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Fixes #10.
Export packages types from the main entry-point.

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Jan 23, 2023
ChristianMurphy
ChristianMurphy reviewed Jan 23, 2023
View reviewed changes
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this @Methuselah96!
I appreciate you!

@wooorm was this change intentional? It looks like d23f808 may have intentionally made this interface private?

I'm good either way, just want to check the intent before signing off.

@wooorm
Copy link
Member

wooorm commented Jan 23, 2023

It's intentional. It was never supposed to be exposed. It's also not documented (it's instead mention explicitly that there are no types exported).

Why do you need this type? Why not use a Node interface from mdast or hast?

@wooorm
Copy link
Member

wooorm commented Jan 23, 2023

Ahh OK it's mdast-util-to-hast that needs a fix!

@github-actions

This comment has been minimized.

Sign in to view
@wooorm wooorm added the 👀 no/external This makes more sense somewhere else label Jan 23, 2023
@wooorm
Copy link
Member

wooorm commented Jan 23, 2023

Thanks, fixed

@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Jan 23, 2023
@Methuselah96 Methuselah96 deleted the export-types branch January 23, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristianMurphy ChristianMurphy ChristianMurphy left review comments

Assignees

No one assigned

Labels

👀 no/external This makes more sense somewhere else 👎 phase/no Post cannot or will not be acted on

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Type PositionLike no longer exported

3 participants

@Methuselah96 @wooorm @ChristianMurphy