calc: Set maximum digit length to 9 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
requested changes
Aug 22, 2024
There was a problem hiding this comment.
Append Close #25 at the end of git commit message, so that that issue will be closed once the commit is merged.
See https://github.blog/news-insights/product-news/closing-issues-via-commit-messages/
jserv
changed the title
jserv
reviewed
Aug 22, 2024
The type of calc->stack[0] is int, and the maximum value for an int is 2,147,483,647. Conservatively, we ensure that when the length reaches 9 digits, pressing the digit button will not increase the number of digits. Close sysprog21#25
|
Thank @Bennctu for contributing. I amended the git commit message. See https://cbea.ms/git-commit/ for improving. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #25, we find that the input number is random if the digits of the number is larger than 9 digits.
The type of calc->stack[0] is int, and the maximum value for an int is 2,147,483,647. Conservatively, we ensure that when the length reaches 9 digits, pressing the digit button will not increase the number of digits.