-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
offset under 25 has "some accel" #25
Comments
just tested, same thing with postscaling with the correspondent offset. |
i believe the error is in accel.c at 181 //TODO: Add different acceleration styles i think this should be if rate >1 |
never mind, problem still persists |
found the bug ill commit a simple fix |
Let me guess: This is PR #27 ? |
yea im no longer shure this was the fix. as for the bug itself, it will depend on your actual speed after prescale. in this case that was somewhere at 700dpi effective. when you run 2 profiles (one with accel and one without) and switch at runtime you can clearly feel the difference. also the acceleration factor has a word to say about this. i wanted to run a jump curve so i ran acceleration at 10.0f i normaly run a very slow flat movement for any regurlar movement and use extreme jump for certain types of fliks in movement (90/180/360 at basically 1 frame flik), so thats why i wanted that high accell. and while i could find some workarounds to reduce the effect it still baffles me that acceleration factor should have anything todo with offset, cus it shouldnt. we should only start to calculate after any offset and stop to calculate at limits |
ok it might jsut be psychosomatic after all placebo is a thing
so in essence i repalce g_Acceleration with tmpaccel, nailed tmp accel to 0f and only if rate is above offset i write the config value for acceleration into that var. to be clear i could be also really easy mistaken as my obervation goes by "feeling". so no claim theres is really such a bug, but if there is, this code as ugly as is will solve it |
one last note, i wonder if it make sense to delete here is my theory, first its no longer needed, second with bigger offsets accerlation pattern changes. but at this point i wonder if it wouldnt be easier to port rawaccels code over instead of reinventing the wheel from scratch |
Im running a jumpcurve at 25.0f at 0.43f prescaler at 1600 naative dpi
if i lower the offeset from 25 to let say 20 even very slow movement becomes kind of accelerated and "slippery"
iam talking here very very low speeds that should be under 5. but seems any movement is affected if offset is lwoer than 25.
the effect seems stronge rwith a higher acceleration factor.
if i set 0.07 as acceleration is very low but still present effect.
if i set acceleration to 10.0f is higher a touch.
(normaly i have sens cap 2, accel 10, offset 25f, to have quick 90 and 180s fliks and run native for all controlled movements aka aim)
now the issue with this is that offset is calculated after prescaler and not native dpi.
that means the lower your prescaler the lower your offset must be.
but with an added murky acceleration (thats kinda unpredictable, it really isnt a stable feeling you can get used to) lowering
prescaler isnt possible at a certain point.
The text was updated successfully, but these errors were encountered: