Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add publish workflow when creating releases #66

Closed
wants to merge 4 commits into from

Conversation

omdxp
Copy link

@omdxp omdxp commented Jun 28, 2022

Hi, I really liked your work here and I wanted to contribute to your project by adding a workflow for a GitHub Action that publish this package automatically to npm registry when creating releases in your repo. You just need to add NODE_AUTH_TOKEN to your repo secrets and you should test it before using it if any thing occurs.

@nexxeln
Copy link
Member

nexxeln commented Jun 28, 2022

Thank you! Would have appreciated if we could have discussed this in an issue first.

We're not making releases on GitHub yet, but this PR definitely made me want. I will not merge this for now, but we're gonna implement releasing on GitHub automatically soon and after that I will merge this.

@omdxp
Copy link
Author

omdxp commented Jun 28, 2022

@nexxeln cool, glad to help!

Co-authored-by: Jam Maligad <31820961+jammaligad@users.noreply.github.com>
@omdxp
Copy link
Author

omdxp commented Jul 7, 2022

@jammaligad done!

@omdxp
Copy link
Author

omdxp commented Jul 10, 2022

@JacobMGEvans it's done

Co-authored-by: Jacob M-G Evans <27247160+JacobMGEvans@users.noreply.github.com>
@omdxp omdxp changed the title Add publish workflow when creating releases feat: add publish workflow when creating releases Jul 12, 2022
@juliusmarminge
Copy link
Member

juliusmarminge commented Jul 20, 2022

I think we should look into merging this @nexxeln @JacobMGEvans

Is there a way to make this work with multiple tags? We have latest, next and beta.

@omdxp
Copy link
Author

omdxp commented Jul 20, 2022

It can be applied using the input from the manual action dispatch:

on:
  workflow_dispatch:
    inputs:
      release-type:
        description: 'Release type (one of): patch, minor, major, prepatch, preminor, premajor, prerelease'
        required: true

@JacobMGEvans
Copy link
Contributor

I think we should look into merging this @nexxeln @JacobMGEvans

Is there a way to make this work with multiple tags? We have latest, next and beta.

Yes there is. You can see release Workflow here https://github.com/cloudflare/wrangler2/blob/main/.github/workflows/release.yml

You can see beta prerelease here https://github.com/cloudflare/wrangler2/blob/main/.github/workflows/prereleases.yml

@juliusmarminge
Copy link
Member

Superseded by #308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants