fixes #206

tabulapdf · Mar 1, 2018 · 01074f3 · 01074f3
1 parent 4e15a50
commit 01074f3
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 0 deletions.
diff --git a/src/main/java/technology/tabula/ObjectExtractorStreamEngine.java b/src/main/java/technology/tabula/ObjectExtractorStreamEngine.java
@@ -195,6 +195,10 @@ private void strokeOrFillPath(boolean isFill) {
                 case PathIterator.SEG_LINETO:
                     end_pos = new Point2D.Float(c[0], c[1]);
 
+                    if (start_pos == null || end_pos == null) {
+                        break;
+                    }
+
                     line = pc.compare(start_pos, end_pos) == -1 ? new Line2D.Float(start_pos, end_pos)
                             : new Line2D.Float(end_pos, start_pos);
 
@@ -216,6 +220,9 @@ private void strokeOrFillPath(boolean isFill) {
                     // segment
                     // back to the point corresponding to the most recent
                     // SEG_MOVETO."
+                    if (start_pos == null || end_pos == null) {
+                        break;
+                    }
                     line = pc.compare(end_pos, last_move) == -1 ? new Line2D.Float(end_pos, last_move)
                             : new Line2D.Float(last_move, end_pos);
 

diff --git a/src/test/java/technology/tabula/TestObjectExtractor.java b/src/test/java/technology/tabula/TestObjectExtractor.java
@@ -126,6 +126,18 @@ public void testTextElementsContainedInPage() throws IOException {
             assertTrue(page.contains(te));
         }
     }
+
+    @Test public void testDoNotNPEInPointComparator() throws IOException {
+        PDDocument pdf_document = PDDocument.load(new File("src/test/resources/technology/tabula/npe_issue_206.pdf"));
+        ObjectExtractor oe = new ObjectExtractor(pdf_document);
+
+        try {
+            Page p = oe.extractPage(1);
+            assertNotNull(p);
+        } catch (NullPointerException e) {
+            fail("NPE in ObjectExtractor " + e.toString());
+        }
+    }
 
     /*
     @Test

diff --git a/src/test/resources/technology/tabula/npe_issue_206.pdf b/src/test/resources/technology/tabula/npe_issue_206.pdf