feat(protocol): support delayed forced inclusion of txs #18883
Merged
+820
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: dantaik <dantaik@users.noreply.github.com> Co-authored-by: xiaodino <ruby@taiko.xyz> Co-authored-by: xiaodino <xiaodino@users.noreply.github.com> Co-authored-by: David <david@taiko.xyz> Co-authored-by: davidtaikocha <davidtaikocha@users.noreply.github.com> Co-authored-by: Anshu Jalan <anshujalan206@gmail.com> Co-authored-by: AnshuJalan <AnshuJalan@users.noreply.github.com> Co-authored-by: davidtaikocha <104078303+davidtaikocha@users.noreply.github.com> Co-authored-by: smtmfft <99081233+smtmfft@users.noreply.github.com> Co-authored-by: smtmfft <smtmfft@users.noreply.github.com> Co-authored-by: maskpp <maskpp266@gmail.com> Co-authored-by: jeff <113397187+cyberhorsey@users.noreply.github.com> Co-authored-by: Gavin Yu <gavin@taiko.xyz> Co-authored-by: YoGhurt111 <23009382+YoGhurt111@users.noreply.github.com> Co-authored-by: Jeffery Walsh <cyberhorsey@gmail.com>
dantaik
changed the title
dantaik
changed the title
cyberhorsey
reviewed
Feb 6, 2025
packages/protocol/contracts/layer1/forced-inclusion/TaikoWrapper.sol
Outdated
Show resolved
Hide resolved
|
@cyberhorsey please also take a closer look at the ForcedInclusionStore.sol code as I have made some modification there. |
8 tasks
|
Guys, this PR is ready for another round of review. I hope this PR can be merged in the next few days before the Pacaya audit starts. |
|
@AnshuJalan it will be great if you can help me check propose-batch related permissions. |
davidtaikocha
approved these changes
Feb 10, 2025
YoGhurt111
approved these changes
Feb 11, 2025
This was referenced Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry that accidentally merged #18826 into this branch.