Skip to content

Commit

Permalink
ensure we pluck out the nullable prop from the props
Browse files Browse the repository at this point in the history
This should help improve migrating to v2 because otherwise the
`nullable` prop (that doesn't do anything) could end up on the
`Fragment` and cause errors.
  • Loading branch information
RobinMalfait committed Apr 14, 2024
1 parent 717812f commit ed1fec6
Showing 1 changed file with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -608,6 +608,9 @@ function ComboboxFn<TValue, TTag extends ElementType = typeof DEFAULT_COMBOBOX_T
multiple = false,
immediate = false,
virtual = null,
// Deprecated, but let's pluck it from the props such that it doesn't end up
// on the `Fragment`
nullable: _nullable,
...theirProps
} = props
let [value = multiple ? [] : undefined, theirOnChange] = useControllable<any>(
Expand Down

0 comments on commit ed1fec6

Please sign in to comment.