Add a way to have variant part be appended as suffix instead of only prefix #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safareli
changed the title
Member
|
I'm not opposed to making this customizable but I don't think I want to do it with a hardcoded option like this, I'd rather figure out a way to handle it with a callback like we support for prefixes: I'd like to solve the "creating new variants using plugins" problem first though in case it helps inform what the best way to support customization would be, so going to close this as is for now. Thanks for the contribution regardless! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds prop variantsAsSuffix to config.options. which once set to true moves adds variant part as suffix instead of prefix.