Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump esp-idf-svc and embassy-time version #161

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

HaoboGu
Copy link
Contributor

@HaoboGu HaoboGu commented Jan 16, 2025

Breaking: Update esp-idf-svc and embassy-time to latest version.

Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
Copy link
Contributor Author

HaoboGu commented Jan 16, 2025

@taks Do you have any ideas about why the CI fails?

@taks
Copy link
Owner

taks commented Jan 16, 2025

@HaoboGu Please try adding "generic-queue-8" feature to embassy-time.

Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
Copy link
Contributor Author

HaoboGu commented Jan 16, 2025

oh it works! thanks @taks

@HaoboGu
Copy link
Contributor Author

HaoboGu commented Jan 16, 2025

according to the doc, the default generic queue size is 64, but why it results in a linker error 🤔?

@taks
Copy link
Owner

taks commented Jan 16, 2025

The doc seems to be incorrect.

If generic-queue-* is not specified, queue_integrated.rs is used in the embassy-time-queue-utils library.
This uses embassy_executor, so the link error occurs.

@HaoboGu
Copy link
Contributor Author

HaoboGu commented Jan 16, 2025

That makes sense. Thanks!

I think this PR is ready to be merged :)

@taks taks merged commit 9c33c98 into taks:main Jan 16, 2025
7 checks passed
@HaoboGu HaoboGu deleted the chore/update_dep branch January 16, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants