Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mutable defaults #40

Closed
aaprasad opened this issue May 7, 2024 · 1 comment
Closed

Remove mutable defaults #40

aaprasad opened this issue May 7, 2024 · 1 comment
Assignees
@aaprasad

Comments

@aaprasad
Copy link
Contributor

aaprasad commented May 7, 2024

I have learned that, in python, mutable defaults are a terrible practice. I've used dictionaries and tensors as defaults all over the place so we need to replace them all with None or some other immutable type.
@aaprasad aaprasad mentioned this issue May 21, 2024
Merged
@aaprasad aaprasad self-assigned this May 21, 2024
@aaprasad
Copy link
Contributor Author

aaprasad commented Jun 3, 2024

completed in #48

@aaprasad aaprasad closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaprasad aaprasad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aaprasad