Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tracker module #70

Merged
merged 29 commits into from
Sep 11, 2024
Merged

Implement tracker module #70

merged 29 commits into from
Sep 11, 2024

Conversation

gitttt-1234
Copy link
Contributor

@gitttt-1234 gitttt-1234 commented Jul 31, 2024

Tracker module: #53

This PR implements a basic tracker with the following features:

  • Candidate generation: Both FixedWindow and LocalQueue methods are supported.
  • Candidate updating using Flow shift
  • Feature representation: Poses, Bounding boxes, Centroids
  • Scoring method: OKS, IoU, Euclidean distance
  • Scoring reduction : Mean, Maximum
  • Track assignment: Greedy, Hungarian

Copy link
Contributor

coderabbitai bot commented Jul 31, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gitttt-1234 gitttt-1234 changed the base branch from main to divya/refactor-pipeline-config July 31, 2024 16:58
@gitttt-1234 gitttt-1234 linked an issue Jul 31, 2024 that may be closed by this pull request
20 tasks
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 96.72978% with 19 lines in your changes missing coverage. Please review.

Project coverage is 97.77%. Comparing base (d8f49a8) to head (58a9715).
Report is 1 commits behind head on divya/fix-topdown-aug.

Files with missing lines Patch % Lines
sleap_nn/tracking/tracker.py 96.47% 6 Missing ⚠️
sleap_nn/tracking/utils.py 92.30% 4 Missing ⚠️
sleap_nn/tracking/candidates/local_queues.py 95.31% 3 Missing ⚠️
sleap_nn/data/edge_maps.py 90.90% 2 Missing ⚠️
sleap_nn/training/model_trainer.py 93.54% 2 Missing ⚠️
sleap_nn/inference/predictors.py 95.00% 1 Missing ⚠️
sleap_nn/tracking/candidates/fixed_window.py 98.07% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           divya/fix-topdown-aug      #70      +/-   ##
=========================================================
- Coverage                  97.96%   97.77%   -0.19%     
=========================================================
  Files                         30       35       +5     
  Lines                       2798     3330     +532     
=========================================================
+ Hits                        2741     3256     +515     
- Misses                        57       74      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from divya/refactor-pipeline-config to divya/refactor-aug-config August 2, 2024 23:50
@gitttt-1234 gitttt-1234 changed the base branch from divya/refactor-aug-config to greg/minimalinstances August 14, 2024 16:48
@talmo talmo changed the title Divya/tracker Implement tracker module Aug 14, 2024
@gitttt-1234 gitttt-1234 marked this pull request as ready for review August 21, 2024 23:56
@gitttt-1234 gitttt-1234 changed the base branch from greg/minimalinstances to divya/fix-topdown-aug August 21, 2024 23:56
@gitttt-1234 gitttt-1234 requested a review from talmo August 22, 2024 00:04
…ps pipeline (#79)

* Add option to automatically compute crop size

* Move find_crop_size to Trainer

* Fix skeleton name

* Add crop size to config

* Add resumable training option

* Add tests fore resuming training

* Fix tests

* Fix test for wandb folder

* LitData Refactor PR1: Get individual functions for data pipelines (#81)

* Add functions for data pipelines

* Add test cases

* Format file

* Add more test cases

* Fix augmentation test
@gitttt-1234 gitttt-1234 merged commit 9767947 into divya/fix-topdown-aug Sep 11, 2024
7 checks passed
gitttt-1234 added a commit that referenced this pull request Sep 11, 2024
* Fix topdown aug

* Implement tracker module (#70)

* Refactor preprocessing config

* Merge train and val data configs

* Remove pipeline name

* Modify backbone_config

* Modify ckpts

* Fix inference tests

* Fix device for inference

* Fix scale in inference

* Fix Predictor

* Modify `bottom_up` to `bottomup`

* Fix bottomup inference

* Fix scale in augmentation

* Add tracker

* Fix tracker queue

* Add local queues

* Modify local queues\

* Add features

* Add optical flow

* Add Optical flow

* Add tracking score

* Refactor candidate update

* Integrate with Predictors

* Fix lint

* Fix tracks

* Resume training and automatically compute crop size for TopDownConfmaps pipeline (#79)

* Add option to automatically compute crop size

* Move find_crop_size to Trainer

* Fix skeleton name

* Add crop size to config

* Add resumable training option

* Add tests fore resuming training

* Fix tests

* Fix test for wandb folder

* LitData Refactor PR1: Get individual functions for data pipelines (#81)

* Add functions for data pipelines

* Add test cases

* Format file

* Add more test cases

* Fix augmentation test
gitttt-1234 added a commit that referenced this pull request Sep 12, 2024
…erpolation (#73)

* Refactor Augmentation config

* Modify ckpts

* Refactor pipeline config (#68)

* Refactor preprocessing config

* Merge train and val data configs

* Remove pipeline name

* Modify backbone_config

* Modify ckpts

* Fix inference tests

* Fix device for inference

* Fix scale in inference

* Fix Predictor

* Modify `bottom_up` to `bottomup`

* Fix bottomup inference

* Fix scale in augmentation

* changed parameters

* Remove `image` key from TopDownConfmaps pipeline (#71)

* Refactor preprocessing config

* Merge train and val data configs

* Remove pipeline name

* Modify backbone_config

* Modify ckpts

* Fix inference tests

* Fix device for inference

* Fix scale in inference

* Fix Predictor

* Modify `bottom_up` to `bottomup`

* Fix bottomup inference

* Fix scale in augmentation

* Test remove image

* Fix instance cropping

* Fix tests

* Remove scale in pipelines

* adjusting the bottomup params

* Fix paf grouping

* Fix test

* Add interpolate function

* Fix tests

* Fix augmentation in TopdownConfmaps pipeline (#78)

* Fix topdown aug

* Implement tracker module (#70)

* Refactor preprocessing config

* Merge train and val data configs

* Remove pipeline name

* Modify backbone_config

* Modify ckpts

* Fix inference tests

* Fix device for inference

* Fix scale in inference

* Fix Predictor

* Modify `bottom_up` to `bottomup`

* Fix bottomup inference

* Fix scale in augmentation

* Add tracker

* Fix tracker queue

* Add local queues

* Modify local queues\

* Add features

* Add optical flow

* Add Optical flow

* Add tracking score

* Refactor candidate update

* Integrate with Predictors

* Fix lint

* Fix tracks

* Resume training and automatically compute crop size for TopDownConfmaps pipeline (#79)

* Add option to automatically compute crop size

* Move find_crop_size to Trainer

* Fix skeleton name

* Add crop size to config

* Add resumable training option

* Add tests fore resuming training

* Fix tests

* Fix test for wandb folder

* LitData Refactor PR1: Get individual functions for data pipelines (#81)

* Add functions for data pipelines

* Add test cases

* Format file

* Add more test cases

* Fix augmentation test

* Revert merging "Fix augmentation in TopdownConfmaps pipeline (#78)"

This reverts commit 9d65cc7.

---------

Co-authored-by: gitttt-1234 <divyasesh11@gmail.com>
Co-authored-by: DivyaSesh <64513125+gitttt-1234@users.noreply.github.com>
Co-authored-by: grquach <101067674+grquach@users.noreply.github.com>
@gitttt-1234 gitttt-1234 removed a link to an issue Sep 12, 2024
20 tasks
@gitttt-1234 gitttt-1234 deleted the divya/tracker branch September 12, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants