-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Type Hints #137
Comments
[self-assigned but feel free to do it for me ;) ] |
Would you accept this as a series of smaller PRs, or would you prefer it land in one fell swoop? I figure incrementally introducing typing will be easier, but that's based on a few minutes of poking around as I integrated something with this API library. |
Definitely. I'd do it in one swoop if I sat down to do it, but anything helps. In my experience 80-90% of type hinting is low hanging fruit, and then you hit the remaining code where you either have to do something inventive or consider tweaking the implementation. So if that turns out to be the case here, we should do the low hanging fruit first so people can start benefitting. |
Thanks! I put up an initial PR to get the baseline stuff out of the way (type checking, config, etc.). Once we're in agreement, I can start landing the bigger pieces of API surface. |
Part of the intention of dropping support for python 2.7 was being able to use type hints. This would help with tehkillerbee/mopidy-tidal#112 as well.
The text was updated successfully, but these errors were encountered: