Add typings for Session #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arusahni
force-pushed
the
feat/session-typing
branch
from
9f8f84e to
7139072
Compare
|
@2e0byo I've just put you as a reviewer on this PR. Feel free to put me as a reviewer, if you are busy rn. |
|
I'll try to go through this weekend. @arusahni as always thanks for the hard work |
|
Howdy - I wanted to bump this in case it fell between the cracks. |
|
@arusahni Sorry, I will take a look asap. |
tehkillerbee
requested review from
tehkillerbee
and removed request for
2e0byo
tehkillerbee
requested changes
Nov 2, 2023
arusahni
force-pushed
the
feat/session-typing
branch
from
7139072 to
95aeb99
Compare
arusahni
force-pushed
the
feat/session-typing
branch
from
95aeb99 to
45858f2
Compare
|
@arusahni Sorry for the lack of activity on this PR. I will do some tests on this and get it merged in one of the next few days. |
|
Works with the latest changes. Some fixes are needed to the tests, but probably unrelated to this PR, as the tests have been broken for some time. I will also update the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on #191. Commits should be reviewed independently as this diff includes changes from that PR, too.
This brings the Session module in line with typings, and cleans up some now-redundant casts. Because mypy is no longer choking on the Session, some issues with existing annotations elsewhere in the project were revealed. This cleans them up, too.
Fixes #137