-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crud: add readview support #372
Conversation
b28cc29
to
a031bf6
Compare
a031bf6
to
c748ffe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your patch! That's a rather nice implementation, but we may improve it in some ways. A couple of things definitely need to be changed, some of them may be ignored for now.
44096c1
to
553ba10
Compare
553ba10
to
b112b73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates. Most of the crucial things seems fine, there are some minor things that should be fixed before merge. And we still lack some tests. You may start to write README API description after adding missing options to .new
and :close
33f36c7
to
73fe4a9
Compare
0b5bea5
to
b2f352c
Compare
ff08beb
to
19b377c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates! Seems awesome, I think I'll merge this one after you resolve remaining comments.
b8b31e0
to
af8bcfa
Compare
Added read view support for select and pairs. Closes #343
af8bcfa
to
93180c9
Compare
Added readview support for select and pairs.
e.g
Closes #343
I didn't forget about