api: make Call = Call17

Closes #235
tarantool · Apr 28, 2023 · 71a7652 · 71a7652
1 parent bdf6496
commit 71a7652
Show file tree

Hide file tree

Showing 16 changed files with 194 additions and 347 deletions.
diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml
@@ -99,11 +99,6 @@ jobs:
           make test
           make testrace
 
-      - name: Run regression tests with call_17
-        run: |
-          make test TAGS="go_tarantool_call_17"
-          make testrace TAGS="go_tarantool_call_17"
-
       - name: Run fuzzing tests
         if: ${{ matrix.fuzzing }}
         run: make fuzzing TAGS="go_tarantool_decimal_fuzzing"
@@ -189,14 +184,6 @@ jobs:
         env:
           TEST_TNT_SSL: ${{matrix.ssl}}
 
-      - name: Run regression tests with call_17
-        run: |
-          source tarantool-enterprise/env.sh
-          make test TAGS="go_tarantool_call_17"
-          make testrace TAGS="go_tarantool_call_17"
-        env:
-          TEST_TNT_SSL: ${{matrix.ssl}}
-
       - name: Run fuzzing tests
         if: ${{ matrix.fuzzing }}
         run: make fuzzing TAGS="go_tarantool_decimal_fuzzing"
@@ -363,12 +350,6 @@ jobs:
           make test
           make testrace
 
-      - name: Run regression tests with call_17
-        run: |
-          cd "${SRCDIR}"
-          make test TAGS="go_tarantool_call_17"
-          make testrace TAGS="go_tarantool_call_17"
-
       - name: Run fuzzing tests
         if: ${{ matrix.fuzzing }}
         run: |

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -20,6 +20,7 @@ Versioning](http://semver.org/spec/v2.0.0.html) except to the first release.
 
 - connection_pool renamed to pool (#239)
 - Use msgpack/v5 instead of msgpack.v2 (#236)
+- Call/NewCallRequest = Call17/NewCall17Request (#235)
 
 ### Removed
 

diff --git a/README.md b/README.md
@@ -30,6 +30,7 @@ faster than other packages according to public benchmarks.
     * [multi package](#multi-package)
     * [pool package](#pool-package)
     * [msgpack.v5](#msgpackv5)
+    * [Call = Call17](#call--call17)
 * [Contributing](#contributing)
 * [Alternative connectors](#alternative-connectors)
 
@@ -66,13 +67,7 @@ This allows us to introduce new features without losing backward compatibility.
    ```
    go_tarantool_ssl_disable
    ```
-2. To change the default `Call` behavior from `Call16` to `Call17`, you can use
-   the build tag:
-   ```
-   go_tarantool_call_17
-   ```
-   **Note:** In future releases, `Call17` may be used as default `Call` behavior.
-3. To run fuzz tests with decimals, you can use the build tag:
+2. To run fuzz tests with decimals, you can use the build tag:
    ```
    go_tarantool_decimal_fuzzing
    ```
@@ -188,6 +183,13 @@ There are also changes in the logic that can lead to errors in the old code,
 to achieve full compliance of behavior between `msgpack.v5` and `msgpack.v2`. So
 we don't go this way. We use standard settings if it possible.
 
+#### Call = Call17
+
+Call requests uses `IPROTO_CALL` instead of `IPROTO_CALL_16`.
+
+So now `Call` = `Call17` and `NewCallRequest` = `NewCall17Request`. A result
+of the requests is an array instead of array of arrays.
+
 ## Contributing
 
 See [the contributing guide](CONTRIBUTING.md) for detailed instructions on how

diff --git a/call_16_test.go b/call_16_test.go
diff --git a/call_17_test.go b/call_17_test.go
diff --git a/const.go b/const.go
@@ -21,6 +21,7 @@ const (
 	IdRequestCode        = 73
 	WatchRequestCode     = 74
 	UnwatchRequestCode   = 75
+	CallRequestCode      = Call17RequestCode
 
 	KeyCode         = 0x00
 	KeySync         = 0x01

diff --git a/const_call_16.go b/const_call_16.go
diff --git a/const_call_17.go b/const_call_17.go
diff --git a/pool/call_16_test.go b/pool/call_16_test.go
diff --git a/pool/call_17_test.go b/pool/call_17_test.go