Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GithubFileUrlGenerator for Github enterprise #17

Closed
tarek360 opened this issue Oct 4, 2018 · 1 comment
Closed

Fix GithubFileUrlGenerator for Github enterprise #17

tarek360 opened this issue Oct 4, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@tarek360
Copy link
Owner

tarek360 commented Oct 4, 2018

github.comshould be dynamic for Github enterprise.

koshry/koshry/src/main/java/io/github/tarek360/koshry/url/GithubFileUrlGenerator.kt

Line 23 in feec152

return "https://github.com/$ownerNameRepoName/pull/$pullRequestId/files#diff-$filePathMd5$line"

@tarek360 tarek360 added the bug Something isn't working label Oct 4, 2018
@tarek360
Copy link
Owner Author

Fixed in:
#15
#18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tarek360