[orchdaemon]: Fixed sairedis record file rotation

What I did
Fix sonic-net/sonic-buildimage#8162

Moved sairedis record file rotation logic out of flush() to fix issue.

Why I did it
Sairedis record file was not releasing the file handle on rotation. This is because the file handle release was inside the flush() which was only being called if a select timeout was triggered. Moved the logic to its own function which is called in the start() loop.

How I verified it
Ran a script to fill log and verified that rotation was happening correctly.

Signed-off-by: Bryan Crossland bryan.crossland@target.com

orchagent/orchdaemon.cpp

@@ -687,6 +687,7 @@ void OrchDaemon::logRotate() {
     }
 }
 
+
 void OrchDaemon::start()
 {
     SWSS_LOG_ENTER();

tests/mock_tests/orchdaemon_ut.cpp

@@ -44,9 +44,9 @@ namespace orchdaemon_test
     };
 
     TEST_F(OrchDaemonTest, logRotate)
-{
-    EXPECT_CALL(mock_sai_switch_, set_switch_attribute( _, _)).WillOnce(Return(SAI_STATUS_SUCCESS));
+    {
+        EXPECT_CALL(mock_sai_switch_, set_switch_attribute( _, _)).WillOnce(Return(SAI_STATUS_SUCCESS));
 
-    orchd->logRotate();
-}
+        orchd->logRotate();
+    }
 }