Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a --keep-v option to not drop v at the beginning of version numbers #6

Merged
merged 2 commits into from
May 2, 2018
Merged

Add a --keep-v option to not drop v at the beginning of version numbers #6

merged 2 commits into from
May 2, 2018

Conversation

samoht
Copy link
Contributor

@samoht samoht commented Apr 18, 2018

/cc @diml

I've done a minimal amount of testing with sexplib0 with dune-release distrib --keep-v and dune-release opam --keep-v and that seems to work fine.

@ghost
Copy link

ghost commented Apr 19, 2018

Thanks!

One thing I'm thinking is that keeping the v prefix is a property of the package. Would it be possible for this setting to be persistent? For instance by writing x-keep-v-prefix: true in th opam file

@ghost
Copy link

ghost commented May 2, 2018

Another idea: we are currently moving forward with the renaming (ocaml/dune#721) and have started adding support for dune-project files. There will be a (version ...) stanza in this file. Whether we want the v prefix or not could be derived from this stanza. For instance you'd write (version %%VERSION%%) (the default) to keep the v prefix and (version %%VERSION_NUM%%) to drop it.

We can expose and API in dune to parse this file so that dune-release can access this information easily. What do you think?

@samoht
Copy link
Contributor Author

samoht commented May 2, 2018

We can expose and API in dune to parse this file so that dune-release can access this information easily. What do you think?

That seems a good idea. Having x-keep-v-prefix: true looks like a hack and I am not sure opam 1.2 will be happy with that.

@ghost ghost mentioned this pull request May 2, 2018
Merged
@samoht samoht merged commit c677653 into master May 2, 2018
@samoht samoht deleted the drop-v branch May 2, 2018 21:50
@samoht
Copy link
Contributor Author

samoht commented May 2, 2018

Merging from now, we will look at how to persist the option later.

samoht added a commit to samoht/opam-repository that referenced this pull request Jun 8, 2018
@samoht
[new release] dune-release (0.2.0)
5604ed6 
CHANGES:

- Remove opam lint warnings for 1.2 files (tarides/dune-release#2, @samoht)
- Add a `--keep-v` option to not drop `v` at the beginning of version
  numbers (tarides/dune-release#6, @samoht)
- Pass `-p <package>` to jbuilder (tarides/dune-release#8, @diml)
- Fix a bug in `Distrib.write_subst` which could cause an infinite loop
  (tarides/dune-release#10, @diml)
- Add a `--dry-run` option to avoid side-effects for all commands (@samoht)
- Rewrite issues numbers in changelog to point to the right repository
  (tarides/dune-release#13, @samoht)
- Stop force pushing tags to `origin`. Instead, just force push the release
  tag directly to the `dev-repo` repository (@samoht)
- Fix publishing distribution when the the tag to publish is not the repository
  HEAD (tarides/dune-release#4, @samoht)
- Do not depend on `opam-publish` anymore. Use configuration files stored
  in `~/.dune` to parametrise the publishing workflow. (@samoht)
@samoht samoht mentioned this pull request Jun 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samoht