Generate base packages rather than copying them in each test #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanReb
added
the
no changelog
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
NathanReb
force-pushed
the
improve-bin-tests
branch
from
8ea8698
to
9d21fc5
Compare
Leonidas-from-XIV
approved these changes
Feb 3, 2022
There was a problem hiding this comment.
I was wondering whether there isn't a better solution of not inlining the data into the executable and copying the files instead. But I guess that could be difficult because one would still require to set up a dependency on the folder containing the repos to make dune copy the opam repo into the _build folder.
So I think this should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
minimal-repoand all of its copies and add an executable, called from the cram test directly, that generates it instead.