-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: IPC on multiwindowed linux apps (fix #11171) #11236
Conversation
Package Changes Through 0e048e3There are 4 changes which include @tauri-apps/api with patch, tauri-bundler with patch, tauri-cli with patch, @tauri-apps/cli with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
@Ynng thanks for investigating and making a PR, I wonder if we can fix this in |
As in fixing the underlying "Cannot register URI scheme xxx more than once"? |
thanks @Ynng, I have decided to incorporate the idea of this PR in wry instead, see tauri-apps/wry#1384 and #11268. Apologies for the inconvenience. @lucasfernog maybe we should merge this as a fix for 2.0.0 because #11268 will require a minor bump. |
/// The label of the webview that requested this command. | ||
pub label: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we are gonna merge this PR as temporary fix, we should avoid adding this field.
let label = parts | ||
.headers | ||
.get(TAURI_WEBVIEW_LABEL_HEADER_NAME) | ||
.ok_or("missing Tauri-Webview-Label header")? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you also fix tests that are failing because of this?
Thanks @amrbashir for the proper fix in wry (tauri-apps/wry#1384 and #11268)! Given that this PR introduces temporary changes across multiple files and a new field in |
@Ynng This PR can still be merged to fix the current released minor, we just need the changes I requested |
closes #11171
InvokeRequest
InvokeRequest