Use `format_callback::format_raw` for channels #13288

oscartbeaumont · 2025-04-23T23:40:45Z

Right now when reloading the webview a channel from the previous page might fire. This will cause some JS code similar to window[_some_id](...) to be injected into the page. When window[_some_id] evaluates it will be undefined as the webview context was reset when the page was reloaded. This will cause the webview to crash, sometimes taking out other JS running on the page with it.

This fix makes use of the existing format_callback::format_raw for parsing data back to the webview which has graceful handling on this condition.

github-actions · 2025-04-23T23:41:12Z

Package Changes Through `7900367`

There are 4 changes which include tauri with minor, @tauri-apps/api with minor, tauri-cli with patch, @tauri-apps/cli with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package	current	next
@tauri-apps/api	2.5.0	2.6.0
tauri	2.5.1	2.6.0
@tauri-apps/cli	2.5.0	2.5.1
tauri-cli	2.5.0	2.5.1

Add another change file through the GitHub UI by following this link.

Read about change files or the docs at github.com/jbolda/covector

crates/tauri/src/ipc/channel.rs

Legend-Master · 2025-04-24T01:50:01Z

crates/tauri/src/ipc/channel.rs

-        let _ = webview_clone.eval(format!(
-          "window['_{callback_id}']({{ end: true, index: {current_index} }})",
-        ));
+        let _ = webview_clone.eval(format!("window['_{callback_id}']()",));


I don't quite understand this change, is this some left over code?

This was just a mistake.

Then why don't we remove it? let _ = webview_clone.eval(format!("",)); doesn't make sense either

Sorry, misunderstood. Fixed.

Legend-Master · 2025-04-24T01:59:41Z

Also a change file like this one would be nice 🙃

oscartbeaumont · 2025-04-24T23:03:57Z

I have applied the fixes and added a changelog.

I have been unable to test these changes as when I run pnpm build I get the following:

> tauri-workspace@0.0.0 build /Users/oscar/Desktop/tauri
> pnpm run -r build

Scope: 6 of 7 workspace projects
examples/api build$ vite build
│ vite v6.2.6 building for production...
│ transforming...
│ ✓ 6 modules transformed.
│ ✗ Build failed in 104ms
│ error during build:
│ [vite]: Rollup failed to resolve import "@tauri-apps/api/core" from "/Users/oscar/Desktop/tauri/examples/api/src/App.svelte".
│ This is most likely unintended because it can break your application at runtime.
│ If you do want to externalize this module explicitly add it to
│ `build.rollupOptions.external`
│     at viteLog (file:///Users/oscar/Desktop/tauri/node_modules/.pnpm/vite@6.2.6_@types+node@22.13.5_jiti@2.4.2_sass@1.77.8_terser@5.39.…
│     at onRollupLog (file:///Users/oscar/Desktop/tauri/node_modules/.pnpm/vite@6.2.6_@types+node@22.13.5_jiti@2.4.2_sass@1.77.8_terser@5…
│     at onLog (file:///Users/oscar/Desktop/tauri/node_modules/.pnpm/vite@6.2.6_@types+node@22.13.5_jiti@2.4.2_sass@1.77.8_terser@5.39.0_…
│     at file:///Users/oscar/Desktop/tauri/node_modules/.pnpm/rollup@4.40.0/node_modules/rollup/dist/es/shared/node-entry.js:20704:32
│     at Object.logger [as onLog] (file:///Users/oscar/Desktop/tauri/node_modules/.pnpm/rollup@4.40.0/node_modules/rollup/dist/es/shared/…
│     at ModuleLoader.handleInvalidResolvedId (file:///Users/oscar/Desktop/tauri/node_modules/.pnpm/rollup@4.40.0/node_modules/rollup/dis…
│     at file:///Users/oscar/Desktop/tauri/node_modules/.pnpm/rollup@4.40.0/node_modules/rollup/dist/es/shared/node-entry.js:21288:26
└─ Failed in 1.1s at /Users/oscar/Desktop/tauri/examples/api
packages/api build$ rollup -c --configPlugin typescript
└─ Running...
packages/cli build$ cross-env TARGET=node napi build --platform --profile release-size-optimized
└─ Running...
/Users/oscar/Desktop/tauri/examples/api:
 ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  api@1.0.0 build: `vite build`
Exit status 1
 ELIFECYCLE  Command failed with exit code 1.

Following the CONTRIBUTING.md this is required to run examples/api which would let me to test if these changes are working correctly.

Legend-Master · 2025-04-25T02:29:53Z

I have been unable to test these changes as when I run pnpm build I get the following:

What if you build the API and CLI and then go to the example/api directory and run pnpm build? I think it might be the API build task deleted the dist folder when regenerating out files while vite is trying to build from them

crates/tauri/src/ipc/format_callback.rs

…s-callback

oscartbeaumont-crabnebula · 2025-04-28T18:42:44Z

What if you build the API and CLI and then go to the example/api directory

The following works:

# in the `/` directory of the repo
pnpm i
cd packages/api
pnpm build
cd ../cli
pnpm build
cd ../../examples/api
pnpm tauri dev

Thanks for your help!

Legend-Master · 2025-04-29T00:45:55Z

Nice catch, good work 🙃

fix it

96b7b46

oscartbeaumont requested a review from a team as a code owner April 23, 2025 23:40

github-project-automation bot added this to Roadmap Apr 23, 2025

github-project-automation bot moved this to 📬Proposal in Roadmap Apr 23, 2025

Legend-Master requested changes Apr 24, 2025

View reviewed changes

github-project-automation bot moved this from 📬Proposal to 🏗 In progress in Roadmap Apr 24, 2025

oscartbeaumont added 2 commits April 25, 2025 07:00

Create change-pr-13288.md

5addf43

fixes

5aa5ad1

Legend-Master reviewed Apr 25, 2025

View reviewed changes

crates/tauri/src/ipc/format_callback.rs Outdated Show resolved Hide resolved

Legend-Master mentioned this pull request Apr 27, 2025

refactor: rework transformCallback #13325

Merged

oscartbeaumont added 2 commits April 28, 2025 11:33

fixes

98eb9ed

Merge remote-tracking branch 'origin' into error-handling-for-channel…

02cd31f

…s-callback

fix .change

7900367

Legend-Master approved these changes Apr 29, 2025

View reviewed changes

Legend-Master merged commit 94b77b3 into tauri-apps:dev Apr 29, 2025
20 checks passed

github-project-automation bot moved this from 🏗 In progress to 🔎 In audit in Roadmap Apr 29, 2025

github-actions bot mentioned this pull request Apr 29, 2025

Apply Version Updates From Current Changes #13282

Merged

oscartbeaumont mentioned this pull request May 8, 2025

[bug] reloading application with custom menu elements results in TypeError: window['_1093741199'] is not a function #13391

Closed

Uh oh!

Use format_callback::format_raw for channels #13288

Use format_callback::format_raw for channels #13288

Uh oh!

Conversation

oscartbeaumont commented Apr 23, 2025

Uh oh!

github-actions bot commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Package Changes Through 7900367

Uh oh!

Uh oh!

Legend-Master Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

oscartbeaumont Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

Legend-Master Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

oscartbeaumont-crabnebula Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

Legend-Master commented Apr 24, 2025

Uh oh!

oscartbeaumont commented Apr 24, 2025

Uh oh!

Legend-Master commented Apr 25, 2025

Uh oh!

Uh oh!

oscartbeaumont-crabnebula commented Apr 28, 2025

Uh oh!

Uh oh!

Legend-Master commented Apr 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Use `format_callback::format_raw` for channels #13288

Use `format_callback::format_raw` for channels #13288

github-actions bot commented Apr 23, 2025 •

edited

Loading

Package Changes Through `7900367`