fix(bundler): custom sign command failing to sign uninstaller executable #13334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
our docs has instructions for how to sign Windows apps using Azure Key Vault: https://tauri.app/distribute/sign/windows/#azure-key-vault the documented approach relies on a relic.conf file, relative to CWD (src-tauri folder). When the NSIS script tries to sign the uninstaller, the working directory is different, so it cannot find that file. This changes the custom sign command to convert file paths to absolute paths to fix this problem.
Contributor
Package Changes Through e32642fThere are 5 changes which include tauri with minor, @tauri-apps/api with minor, tauri-bundler with patch, tauri-cli with patch, @tauri-apps/cli with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
amrbashir
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
our docs has instructions for how to sign Windows apps using Azure Key Vault: https://tauri.app/distribute/sign/windows/#azure-key-vault
the documented approach relies on a relic.conf file, relative to CWD (src-tauri folder). When the NSIS script tries to sign the uninstaller, the working directory is different, so it cannot find that file.
This changes the custom sign command to convert file paths to absolute paths to fix this problem.