-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix(macros): stack overflow in invoke handler #14170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(macros): stack overflow in invoke handler #14170
Conversation
Package Changes Through 810e9e9There are 9 changes which include @tauri-apps/api with minor, tauri-cli with minor, tauri-utils with minor, tauri-runtime-wry with minor, tauri-runtime with minor, tauri with minor, tauri-bundler with minor, @tauri-apps/cli with minor, tauri-macros with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
@Honghe could you give this a try in your app and see if it indeed fixes the problem? |
It works. Honghe/clash-verge-rev@64efdfb#diff-fe4c6a80a21e81339e2e0faeb9134d0f9636c168987df13c8abf1927a1caee39 |
|
Hey @FabianLars and @Legend-Master . When do you plan to push the next bugfix release? This bug has a big impact on our community and prevents many users from using the software. Should we use the git version for temporary? |
|
hmm the branch is already polluted with minor changes but since we'll all be out of office for the next 2-3 weeks i'll see if i can release a small minor today. |
Hello FabianLars, I wonder if tauri would publish the new release this month? |
|
yes, sorry for the delay on that one |
Upstream Tauri fixed the stack overflow in the invoke handler (tauri-apps/tauri#14170) in v2.9.0, so we can safely use opt-level 3 now.
Fix the stack overflow when having too many commands in a single invoke handler in release build
Fix #14167
So it turned out we can't really rely on the compiler to optimize this away, let's remove the
inline(always)in release build as wellReferences: