Skip to content

Conversation

@Legend-Master
Copy link
Contributor

@Legend-Master Legend-Master commented Sep 8, 2025

Fix the stack overflow when having too many commands in a single invoke handler in release build

Fix #14167

So it turned out we can't really rely on the compiler to optimize this away, let's remove the inline(always) in release build as well

References:

@Legend-Master Legend-Master requested a review from a team as a code owner September 8, 2025 04:54
@github-project-automation github-project-automation bot moved this to 📬Proposal in Roadmap Sep 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

Package Changes Through 810e9e9

There are 9 changes which include @tauri-apps/api with minor, tauri-cli with minor, tauri-utils with minor, tauri-runtime-wry with minor, tauri-runtime with minor, tauri with minor, tauri-bundler with minor, @tauri-apps/cli with minor, tauri-macros with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.8.0 2.9.0
tauri-utils 2.7.0 2.8.0
tauri-bundler 2.6.1 2.7.0
tauri-runtime 2.8.0 2.9.0
tauri-runtime-wry 2.8.1 2.9.0
tauri-codegen 2.4.0 2.4.1
tauri-macros 2.4.0 2.4.1
tauri-plugin 2.4.0 2.4.1
tauri-build 2.4.1 2.4.2
tauri 2.8.5 2.9.0
@tauri-apps/cli 2.8.4 2.9.0
tauri-cli 2.8.4 2.9.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@Legend-Master
Copy link
Contributor Author

@Honghe could you give this a try in your app and see if it indeed fixes the problem?

Honghe added a commit to Honghe/clash-verge-rev that referenced this pull request Sep 8, 2025
@Honghe
Copy link

Honghe commented Sep 8, 2025

@Honghe could you give this a try in your app and see if it indeed fixes the problem?

It works. Honghe/clash-verge-rev@64efdfb#diff-fe4c6a80a21e81339e2e0faeb9134d0f9636c168987df13c8abf1927a1caee39

@Legend-Master Legend-Master merged commit 69476d8 into tauri-apps:dev Sep 8, 2025
20 checks passed
@github-project-automation github-project-automation bot moved this from 📬Proposal to 🔎 In audit in Roadmap Sep 8, 2025
@Legend-Master Legend-Master deleted the remove-inline-command-wrapper branch September 8, 2025 09:38
@Tunglies
Copy link
Contributor

Tunglies commented Sep 9, 2025

Hey @FabianLars and @Legend-Master . When do you plan to push the next bugfix release? This bug has a big impact on our community and prevents many users from using the software. Should we use the git version for temporary?

@FabianLars
Copy link
Member

hmm the branch is already polluted with minor changes but since we'll all be out of office for the next 2-3 weeks i'll see if i can release a small minor today.

@Tunglies
Copy link
Contributor

Tunglies commented Oct 8, 2025

hmm the branch is already polluted with minor changes but since we'll all be out of office for the next 2-3 weeks i'll see if i can release a small minor today.

Hello FabianLars, I wonder if tauri would publish the new release this month?

@FabianLars
Copy link
Member

yes, sorry for the delay on that one

Tunglies added a commit to clash-verge-rev/clash-verge-rev that referenced this pull request Oct 20, 2025
Upstream Tauri fixed the stack overflow in the invoke handler
(tauri-apps/tauri#14170) in v2.9.0,
so we can safely use opt-level 3 now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 In audit

Development

Successfully merging this pull request may close these issues.

[bug] The latest tauri 2.8.5 with tauri-build 2.4.1 introduce a stack overflow

4 participants