Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning messages when specifying lists of confidence intervals #136

Closed
khusmann opened this issue Jul 22, 2020 · 2 comments
Closed

warning messages when specifying lists of confidence intervals #136

khusmann opened this issue Jul 22, 2020 · 2 comments
Assignees

Comments

@khusmann
Copy link
Contributor

Hi, it's me again :)

Getting these warning messages when specifying lists of confidence intervals:

require(umx)
data(demoOneFactor)
manifests = names(demoOneFactor)
m1 = umxRAM("One Factor", data = demoOneFactor, type = "cov",
	umxPath("G", to = manifests),
	umxPath(var = manifests),
	umxPath(var = "G", fixedAt = 1)
)
m1 = umxCI(m1, c("x1_with_x1", "x2_with_x2"), run= "yes")

Output is as expected, but with warnings:

1: In if (is.na(which)) { :
  the condition has length > 1 and only the first element will be used
2: In if (which == "ALL") { :
  the condition has length > 1 and only the first element will be used

Looks like those are coming from
https://github.com/tbates/umx/blob/master/R/fit_and_reporting.R#L754 and https://github.com/tbates/umx/blob/master/R/fit_and_reporting.R#L738

Perhaps there should be a different arg-checking flow when which is a vector?

@tbates tbates self-assigned this Jul 22, 2020
@tbates tbates closed this as completed in 4f8ee2c Jul 22, 2020
@tbates
Copy link
Owner

tbates commented Jul 22, 2020

should have had a test case for that. Fixed now!

@khusmann
Copy link
Contributor Author

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants