Skip to content

Commit

Permalink
roachtest: don't fail tests based on slow health checker
Browse files Browse the repository at this point in the history
We know there can be a backlog of Raft snapshots at the beginning of the
test. This isn't ideal, but we know about it and have cockroachdb#32046 tracking
it.

Closes cockroachdb#32859.

Release note: None
  • Loading branch information
tbg committed Dec 11, 2018
1 parent 1cd7dcf commit b7c596d
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion pkg/cmd/roachtest/restore.go
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,10 @@ func (hc *HealthChecker) Runner(ctx context.Context) (err error) {
}

if elapsed := timeutil.Since(tBegin); elapsed > 10*time.Second {
return errors.Errorf("health check against node %d took %s", nodeIdx, elapsed)
err := errors.Errorf("health check against node %d took %s", nodeIdx, elapsed)
logger.Printf(err.Error() + "\n")
// TODO(tschottdorf): see method comment.
// return err
}
}
}
Expand Down

0 comments on commit b7c596d

Please sign in to comment.