From 86cc26a44fc88e20d7cd3d2a2b1b635865458c5d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Nicol=C3=B2=20Ribaudo?= <nribaudo@igalia.com>
Date: Fri, 23 Aug 2024 15:15:30 +0200
Subject: [PATCH] Review by jmdyck

---
 spec.html | 27 ++++++++++++++++++---------
 1 file changed, 18 insertions(+), 9 deletions(-)

diff --git a/spec.html b/spec.html
index f0e8a9334d..a2c6e75259 100644
--- a/spec.html
+++ b/spec.html
@@ -9879,11 +9879,19 @@ <h1>Static Semantics: PropName ( ): a String or ~empty~</h1>
       <emu-alg>
         1. Return the PropName of |PropertyName|.
       </emu-alg>
-      <emu-grammar>LiteralPropertyName : IdentifierName</emu-grammar>
+      <emu-grammar>
+        LiteralPropertyName : IdentifierName
+
+        AttributeKey : IdentifierName
+      </emu-grammar>
       <emu-alg>
         1. Return the StringValue of |IdentifierName|.
       </emu-alg>
-      <emu-grammar>LiteralPropertyName : StringLiteral</emu-grammar>
+      <emu-grammar>
+        LiteralPropertyName : StringLiteral
+
+        AttributeKey : StringLiteral
+      </emu-grammar>
       <emu-alg>
         1. Return the SV of |StringLiteral|.
       </emu-alg>
@@ -26214,7 +26222,7 @@ <h1>ModuleRequest Records</h1>
         </emu-table>
 
         <p>A <dfn id="loadedmodulerequest-record" variants="LoadedModuleRequest Records">LoadedModuleRequest Record</dfn> represents the request to import a module together with the resulting Module Record. It consists of the same fields defined in table <emu-xref href="#table-modulerequest-fields"></emu-xref>, with the addition of [[Module]]:</p>
-        <emu-table id="table-loadedmodulerequest-fields" caption="LoadedModuleRequest Record fields">
+        <emu-table id="table-loadedmodulerequest-fields" caption="LoadedModuleRequest Record Fields">
           <table>
             <tr>
               <th>
@@ -26387,14 +26395,14 @@ <h1>Static Semantics: ModuleRequests ( ): a List of ModuleRequest Records</h1>
           ExportDeclaration : `export` ExportFromClause FromClause `;`
         </emu-grammar>
         <emu-alg>
-          1. Let _specifier_ be SV of |FromClause|.
+          1. Let _specifier_ be the SV of |FromClause|.
           1. Return a List whose sole element is the ModuleRequest Record { [[Specifier]]: _specifier_, [[Attributes]]: « » }.
         </emu-alg>
         <emu-grammar>
           ExportDeclaration : `export` ExportFromClause FromClause WithClause `;`
         </emu-grammar>
         <emu-alg>
-          1. Let _specifier_ be SV of |FromClause|.
+          1. Let _specifier_ be the SV of |FromClause|.
           1. Let _attributes_ be WithClauseToAttributes of |WithClause|.
           1. Return a List whose sole element is the ModuleRequest Record { [[Specifier]]: _specifier_, [[Attributes]]: _attributes_ }.
         </emu-alg>
@@ -28519,7 +28527,7 @@ <h1>
         <emu-alg>
           1. If _result_ is a normal completion, then
             1. If _referrer_.[[LoadedModules]] contains a LoadedModuleRequest Record _record_ such that ModuleRequestsEqual(_record_, _moduleRequest_) is *true*, then
-              1. Assert: _record_.[[Module]] is _result_.[[Value]].
+              1. Assert: _record_.[[Module]] and _result_.[[Value]] are the same Module Record.
             1. Else,
               1. Append the LoadedModuleRequest Record { [[Specifier]]: _moduleRequest_.[[Specifier]], [[Attributes]]: _moduleRequest_.[[Attributes]], [[Module]]: _result_.[[Value]] } to _referrer_.[[LoadedModules]].
           1. If _payload_ is a GraphLoadingState Record, then
@@ -28788,7 +28796,7 @@ <h1>
         </emu-alg>
       </emu-clause>
 
-      <emu-clause id="sec-with-clause-to-attributes" type="sdo">
+      <emu-clause id="sec-withclausetoattributes" type="sdo">
         <h1>Static Semantics: WithClauseToAttributes ( ): a List of ImportAttribute Records</h1>
         <dl class="header">
         </dl>
@@ -28812,14 +28820,14 @@ <h1>Static Semantics: WithClauseToAttributes ( ): a List of ImportAttribute Reco
         <emu-grammar>WithEntries : AttributeKey `:` StringLiteral</emu-grammar>
         <emu-alg>
           1. Let _key_ be the PropName of |AttributeKey|.
-          1. Let _entry_ be the ImportAttribute Record { [[Key]]: _key_, [[Value]]: SV of |StringLiteral| }.
+          1. Let _entry_ be the ImportAttribute Record { [[Key]]: _key_, [[Value]]: the SV of |StringLiteral| }.
           1. Return « _entry_ ».
         </emu-alg>
 
         <emu-grammar>WithEntries : AttributeKey `:` StringLiteral `,` WithEntries</emu-grammar>
         <emu-alg>
           1. Let _key_ be the PropName of |AttributeKey|.
-          1. Let _entry_ be the ImportAttribute Record { [[Key]]: _key_, [[Value]]: SV of |StringLiteral| }.
+          1. Let _entry_ be the ImportAttribute Record { [[Key]]: _key_, [[Value]]: the SV of |StringLiteral| }.
           1. Let _rest_ be WithClauseToAttributes of |WithEntries|.
           1. Return the list-concatenation of « _entry_ » and _rest_.
         </emu-alg>
@@ -50476,6 +50484,7 @@ <h1>Scripts and Modules</h1>
     <emu-prodref name="ImportedBinding"></emu-prodref>
     <emu-prodref name="WithClause"></emu-prodref>
     <emu-prodref name="WithEntries"></emu-prodref>
+    <emu-prodref name="AttributeKey"></emu-prodref>
     <emu-prodref name="ExportDeclaration"></emu-prodref>
     <emu-prodref name="ExportFromClause"></emu-prodref>
     <emu-prodref name="NamedExports"></emu-prodref>