Skip to content

RegExp Processing of CharacterClassEscape for \W should be the same as !\w with unicode and ignoreCase flags. #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
msaboff wants to merge 2 commits into from
Closed

RegExp Processing of CharacterClassEscape for \W should be the same as !\w with unicode and ignoreCase flags. #516

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1179cb8
Proposed RegExp CharacterClassEscape changes for \W/ui
Apr 4, 2016
1944b45
Minor corrections.
Apr 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions spec.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28110,8 +28110,8 @@ <h1>AtomEscape</h1>
</emu-alg>
<p>The production <emu-grammar>AtomEscape :: CharacterClassEscape</emu-grammar> evaluates as follows:</p>
<emu-alg>
1. Evaluate |CharacterClassEscape| to obtain a CharSet _A_.
1. Call CharacterSetMatcher(_A_, *false*) and return its Matcher result.
1. Evaluate |CharacterClassEscape| to obtain a CharSet _A_ and a Boolean _invert_.
1. Call CharacterSetMatcher(_A_, _invert_) and return its Matcher result.
</emu-alg>
<emu-note>
<p>An escape sequence of the form `\\` followed by a nonzero decimal number _n_ matches the result of the _n_th set of capturing parentheses (see 0). It is an error if the regular expression has fewer than _n_ capturing parentheses. If the regular expression has _n_ or more capturing parentheses but the _n_th one is *undefined* because it has not captured anything, then the backreference always succeeds.</p>
Expand Down Expand Up @@ -28308,10 +28308,10 @@ <h1>DecimalEscape</h1>
<!-- es6num="21.2.2.12" -->
<emu-clause id="sec-characterclassescape">
<h1>CharacterClassEscape</h1>
<p>The production <emu-grammar>CharacterClassEscape :: `d`</emu-grammar> evaluates by returning the ten-element set of characters containing the characters `0` through `9` inclusive.</p>
<p>The production <emu-grammar>CharacterClassEscape :: `D`</emu-grammar> evaluates by returning the set of all characters not included in the set returned by <emu-grammar>CharacterClassEscape :: `d`</emu-grammar> .</p>
<p>The production <emu-grammar>CharacterClassEscape :: `s`</emu-grammar> evaluates by returning the set of characters containing the characters that are on the right-hand side of the |WhiteSpace| or |LineTerminator| productions.</p>
<p>The production <emu-grammar>CharacterClassEscape :: `S`</emu-grammar> evaluates by returning the set of all characters not included in the set returned by <emu-grammar>CharacterClassEscape :: `s`</emu-grammar> .</p>
<p>The production <emu-grammar>CharacterClassEscape :: `d`</emu-grammar> evaluates by returning the ten-element set of characters containing the characters `0` through `9` inclusive and the Boolean *false*.</p>
<p>The production <emu-grammar>CharacterClassEscape :: `D`</emu-grammar> evaluates by returning the set returned by <emu-grammar>CharacterClassEscape :: `d`</emu-grammar> and the Boolean *true*.</p>
<p>The production <emu-grammar>CharacterClassEscape :: `s`</emu-grammar> evaluates by returning the set of characters containing the characters that are on the right-hand side of the |WhiteSpace| or |LineTerminator| productions and the Boolean *false*.</p>
<p>The production <emu-grammar>CharacterClassEscape :: `S`</emu-grammar> evaluates by returning the set returned by <emu-grammar>CharacterClassEscape :: `s`</emu-grammar> and the Boolean *true*.</p>
<p>The production <emu-grammar>CharacterClassEscape :: `w`</emu-grammar> evaluates by returning the set of characters containing the sixty-three characters:</p>
<figure>
<table class="lightweight-table">
Expand Down Expand Up @@ -28544,7 +28544,8 @@ <h1>CharacterClassEscape</h1>
</tbody>
</table>
</figure>
<p>The production <emu-grammar>CharacterClassEscape :: `W`</emu-grammar> evaluates by returning the set of all characters not included in the set returned by <emu-grammar>CharacterClassEscape :: `w`</emu-grammar> .</p>
<p>and the Boolean *false*.</p>
Copy link
Member

@ljharb ljharb Apr 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line still seems like it should be reverted?

Copy link
Member

@mathiasbynens mathiasbynens Apr 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The markup around this area looks really weird (closing </tbody> without a matching start tag etc.) but this line, at least, is intentional. It’s the continuation of the sentence on line https://github.com/tc39/ecma262/pull/516/files/1944b451b767e30575150204d0d28a8ae270a3a5#diff-3540caefa502006d8a33cb1385720803L28315.

Copy link
Contributor Author

@msaboff msaboff Apr 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to suggestions for a different place to add the "and the Boolean false." then after the table.

<p>The production <emu-grammar>CharacterClassEscape :: `W`</emu-grammar> evaluates by returning the set returned by <emu-grammar>CharacterClassEscape :: `w`</emu-grammar> and the Boolean *true*.</p>
</emu-clause>

<!-- es6num="21.2.2.13" -->
Expand Down