Normative: When formatting currency values, only use data on the number of minor units used to display that currency when using standard notation. #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er of minor units used to display that currency when using standard notation. Previously this data was inappropriately used to set the number of fractional digits displayed when formatting currency values in scientific, engineering, and compact notations. See issue tc39#912.
sffc
approved these changes
Sep 26, 2024
gibson042
approved these changes
Sep 26, 2024
|
P.S. We should also try to cover this in test262. |
ben-allen
added
needs tests
has consensus
|
(EDIT: wrong issue) |
|
I believe this is presented to Oct TC39 meeting and still waiting for Mozilla to express their opinion. |
FrankYFTang
reviewed
Oct 11, 2024
| @@ -35,6 +35,9 @@ <h1>Intl.NumberFormat ( [ _locales_ [ , _options_ ] ] )</h1> | |||
| 1. Let _style_ be _numberFormat_.[[Style]]. | |||
| 1. If _style_ is *"currency"*, then | |||
| 1. Let _currency_ be _numberFormat_.[[Currency]]. | |||
There was a problem hiding this comment.
Why is the line " Let currency be numberFormat.[[Currency]]." not inside the same if block of
1. Let _cDigits_ be CurrencyDigits(_currency_).
1. Let _mnfdDefault_ be _cDigits_.
1. Let _mxfdDefault_ be _cDigits_.
Nowhere else need the value of currency in this AO, right?
ben-allen
added
has consensus (TG1)
|
Achieved consensus at October 24 TC39 plenary |
hubot
pushed a commit
to v8/v8
that referenced
this pull request
Oct 17, 2024
Spec: tc39/ecma402#925 Bug: 372731679 Change-Id: I7c7bd4974f21c64a3905eb817983636941f410d5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5925080 Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#96641}
ben-allen
added a commit
to ben-allen/test262
that referenced
this pull request
Oct 21, 2024
…ncy" style and "compact", "engineering", and "scientific" notations. Related PR: tc39/ecma402#925
ben-allen
added a commit
to ben-allen/test262
that referenced
this pull request
Oct 29, 2024
…ncy" style and "compact", "engineering", and "scientific" notations. Related PR: tc39/ecma402#925
ptomato
pushed a commit
to ben-allen/test262
that referenced
this pull request
Oct 30, 2024
…ncy" style and "compact", "engineering", and "scientific" notations. Related PR: tc39/ecma402#925
ptomato
pushed a commit
to tc39/test262
that referenced
this pull request
Oct 30, 2024
…ncy" style and "compact", "engineering", and "scientific" notations. Related PR: tc39/ecma402#925
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Nov 26, 2024
…spidermonkey-reviewers,dminor Implement the changes from <tc39/ecma402#925>. Test coverage: <tc39/test262#4274> Differential Revision: https://phabricator.services.mozilla.com/D228589
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 27, 2024
…spidermonkey-reviewers,dminor Implement the changes from <tc39/ecma402#925>. Test coverage: <tc39/test262#4274> Differential Revision: https://phabricator.services.mozilla.com/D228589
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this data was inappropriately used to set the number of fractional digits displayed when formatting currency values in scientific, engineering, and compact notations. Fix #912.