Skip to content
This repository has been archived by the owner on Jan 25, 2022. It is now read-only.

Remove quarters from best fit #12

Closed
zbraniecki opened this issue Jan 16, 2017 · 1 comment
Closed

Remove quarters from best fit #12

zbraniecki opened this issue Jan 16, 2017 · 1 comment

Comments

@zbraniecki
Copy link
Member

In the current spec language quarters will never be selected by the GetBestMatchUnit because they overlap months.

I suggest that we remove it from the best fit scenario, and leave it only for manual selection with {unit: 'quarter'}.
@caridy
Copy link
Collaborator

caridy commented Mar 17, 2017

If we remove best fit entirely, then this is not a problem. Let's way for that to clear up, so we know what to do.

@rxaviers rxaviers mentioned this issue Mar 20, 2017
Merged
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@caridy @zbraniecki