Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normative: Fix bug with PlainDateTime since/until near month boundaries #2838

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

arshaw
Copy link
Contributor

@arshaw arshaw commented May 14, 2024

Fix for #2820

Fix bug where PlainDateTime since/until would maintain date/time-diff sign compatibility by backing-off from wrong end and erroneously falling across month boundaries

Tests: https://github.com/tc39/test262/pull/4078/files

@arshaw arshaw changed the title Editorial: Fix bug with PlainDateTime since/until near month boundaries Normative: Fix bug with PlainDateTime since/until near month boundaries May 14, 2024
@arshaw
Copy link
Contributor Author

arshaw commented May 14, 2024

CC @ptomato, @justingrant and team

Copy link
Collaborator

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Should I add a commit updating the spec text, or would you still like to do that?

@ptomato ptomato mentioned this pull request May 14, 2024
91 tasks
@arshaw
Copy link
Contributor Author

arshaw commented May 14, 2024

@ptomato, I'd be really appreciative of some help with the spec text

.gitmodules Outdated Show resolved Hide resolved
… sign compatibility by backing-off from wrong end and erroneously falling across month boundaries
@ptomato ptomato force-pushed the 2820-pdt-diff-month-boundary branch from 1e36143 to 25d5e3e Compare May 15, 2024 19:28
ptomato added 2 commits May 15, 2024 12:28
Spec text changes corresponding to previous commit, fixing bug where
PlainDateTime since/until would maintain date/time-diff sign compatibility
by backing-off from wrong end and erroneously falling across month
boundaries.
@ptomato
Copy link
Collaborator

ptomato commented Jun 13, 2024

This normative change reached consensus at the TC39 meeting of 2024-06-12.

@ptomato ptomato merged commit 6495921 into tc39:main Jun 13, 2024
5 checks passed
@ptomato ptomato deleted the 2820-pdt-diff-month-boundary branch June 13, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants